Skip to content

feat(frontend): preview an operator's result when hovering it on the canvas - #9058

Draft
kz930 wants to merge 3 commits into
apache:mainfrom
kz930:feat/9057-pinned-result-windows
Draft

kz930 wants to merge 3 commits into
apache:mainfrom
kz930:feat/9057-pinned-result-windows

Conversation

@kz930

@kz930 kz930 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Resting the pointer on an operator for half a second shows a card beside it with the operator's first rows and its size, or its error, or how to keep a result the run did not keep. A pointer passing over, dragging, or a click opens nothing, and the card lingers a moment so the pointer can move into it. An operator with several outputs says the rows are the first output's. The preview can be turned off under Layers, and stays off while the heat-map overlay is on.

The first rows come from a request of their own, so a preview never moves the result table's page or reads its cache.

pr3-1-hover-card

This needs #9054, so the diff includes its commit until #9054 merges. The PR's own change is the last commit.

Any related issues, documentation, discussions?

Closes #9057. Part of #9052. Design discussed in #8842.

How was this PR tested?

A new spec for the hover card covers a table's rows and size, an error, a chart, no result, and several outputs. New cases in the workflow editor's spec cover the delay before the card opens and the moment it lingers, and the result service's spec covers fetching the first rows without moving the table. The affected frontend specs pass.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

@kz930

kz930 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

@carloea2 could you take a look at this when you have a chance? It stays a draft until #9054 merges, but its own change, the last commit, is ready for review.

Every external output port of an operator that keeps its result is
stored, but results were only ever read from the first port, so a
Split's second output or an If's True branch could not be shown.

A pagination request can now name the output port to read, with the
first port as the default, and the reply carries the port it read and
that port's row count. The live result updates keep following the
first port, so a client paging another port takes the count from the
reply. The result store's count per operator now comes from the first
port too; it was built from every stored port, so a terminal Split's
second output could replace its first output's count.

On the frontend, the result service gives each extra port its own
pagination service, which names its port in its requests, keeps no
page cache and takes its row count from each reply, and every port's
service takes its schema only from replies to its own requests. The
result table and its row detail can show any port.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kz930
kz930 force-pushed the feat/9057-pinned-result-windows branch from 083308b to 99dfefa Compare October 20, 2026 23:26
@kz930 kz930 changed the title feat(frontend): preview an operator's result on hover, and pin it beside the operator feat(frontend): preview an operator's result when hovering it on the canvas Oct 20, 2026
kz930 and others added 2 commits October 20, 2026 16:37
Switching the table to another output port left the previous port's
rows on screen when the new port was empty, with the loading state
never ending, and a late reply for the previous port could replace the
new port's rows. A port change now starts from an empty table, a reply
for an operator or port no longer shown is dropped, and an empty page
ends the loading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…canvas

Resting the pointer on an operator for half a second shows a card
beside it with the operator's first rows and its size, or its error,
or how to keep a result the run did not keep. A pointer passing over,
dragging, or a click opens nothing, and the card lingers a moment so
the pointer can move into it. An operator with several outputs says
the rows are the first output's. The preview can be turned off under
Layers, and stays off while the heat-map overlay is on.

The first rows come from a request of their own, so a preview never
moves the result table's page or reads its cache.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kz930
kz930 force-pushed the feat/9057-pinned-result-windows branch from 99dfefa to a64630b Compare October 20, 2026 23:40
@kz930

kz930 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

@carloea2 heads-up: this PR was reorganized to split the work more evenly. It now holds only the hover preview; the pinned windows moved to #9063. Its own change is still the last commit.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @aglinxinyuan, @yangzhang75, @Ma77Ball
    You can notify them by mentioning @aglinxinyuan, @yangzhang75, @Ma77Ball in a comment.

@github-actions github-actions Bot added feature engine frontend Changes related to the frontend GUI labels Oct 21, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.00000% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.35%. Comparing base (22b82a2) to head (a64630b).

Files with missing lines Patch % Lines
...onent/workflow-editor/workflow-editor.component.ts 78.37% 4 Missing and 4 partials ⚠️
...esult-preview/operator-result-preview.component.ts 89.06% 0 Missing and 7 partials ⚠️
...c/app/workspace/component/menu/menu.component.html 50.00% 2 Missing ⚠️
...ervice/workflow-graph/model/joint-graph-wrapper.ts 60.00% 2 Missing ⚠️
...src/app/workspace/component/menu/menu.component.ts 66.66% 1 Missing ⚠️
...result-table-frame/result-table-frame.component.ts 95.00% 0 Missing and 1 partial ⚠️
...ult-preview/operator-result-preview.component.html 97.22% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9058      +/-   ##
============================================
+ Coverage     92.33%   92.35%   +0.01%     
+ Complexity     5045     5044       -1     
============================================
  Files          1261     1263       +2     
  Lines         54120    54302     +182     
  Branches       6768     6805      +37     
============================================
+ Hits          49974    50148     +174     
+ Misses         2486     2476      -10     
- Partials       1660     1678      +18     
Flag Coverage Δ *Carryforward flag
access-control-service 77.38% <ø> (ø) Carriedforward from 13c1294
agent-service 99.16% <ø> (ø) Carriedforward from 13c1294
amber 87.31% <ø> (-0.01%) ⬇️ Carriedforward from 13c1294
computing-unit-managing-service 60.48% <ø> (ø) Carriedforward from 13c1294
config-service 87.37% <ø> (ø) Carriedforward from 13c1294
file-service 82.00% <ø> (ø) Carriedforward from 13c1294
frontend 96.55% <89.00%> (-0.01%) ⬇️
notebook-migration-service 83.73% <ø> (ø) Carriedforward from 13c1294
pyamber 98.57% <ø> (ø) Carriedforward from 13c1294
workflow-compiling-service 72.43% <ø> (ø) Carriedforward from 13c1294

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine feature frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preview an operator's result when hovering it on the canvas

2 participants