[UUID 6/8] UUID multi-stage engine (planner + runtime) - #18874
Open
xiangfu0 wants to merge 4 commits into
Open
Conversation
This was referenced Jun 29, 2026
xiangfu0
force-pushed
the
uuid-split/06-mse-planner-runtime
branch
3 times, most recently
from
June 30, 2026 09:14
7a7cf63 to
22f38d3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18874 +/- ##
============================================
- Coverage 66.65% 66.61% -0.05%
Complexity 1423 1423
============================================
Files 3443 3446 +3
Lines 218632 218968 +336
Branches 34793 34885 +92
============================================
+ Hits 145726 145857 +131
- Misses 61192 61376 +184
- Partials 11714 11735 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
uuid-split/06-mse-planner-runtime
branch
7 times, most recently
from
July 7, 2026 07:08
763c96a to
96284ae
Compare
xiangfu0
force-pushed
the
uuid-split/06-mse-planner-runtime
branch
11 times, most recently
from
July 14, 2026 08:03
3e1c95c to
f41f8ea
Compare
xiangfu0
force-pushed
the
uuid-split/06-mse-planner-runtime
branch
10 times, most recently
from
July 21, 2026 08:10
1cf12f0 to
bd7f7af
Compare
xiangfu0
force-pushed
the
uuid-split/06-mse-planner-runtime
branch
from
July 22, 2026 08:11
bd7f7af to
c6669fe
Compare
This was referenced Jul 27, 2026
xiangfu0
force-pushed
the
uuid-split/06-mse-planner-runtime
branch
6 times, most recently
from
August 7, 2026 09:28
749583d to
7c23307
Compare
Adds UUID handling to the predicate evaluators, so =, !=, IN, NOT IN and range predicates work against a UUID column on both the raw and the dictionary path. UUID follows the pattern TIMESTAMP already uses: a logical type whose stored type does the work. The literal is parsed to its 16-byte stored form once, when the evaluator is built, and from there the existing BYTES evaluators apply -- no per-value conversion in the scan loop. The dictionary path needs no UUID branch: Dictionary#getStoredValue returns hex for a UUID column and indexOf(String) hex-decodes, so the existing String-keyed lookup is already correct. PredicateUtils renders the literal to that hex form for those String-typed lookup APIs. Split into apache#19181 (CAST), apache#19182 (bloom filter pruning) and apache#19183 (transform functions); this PR is now just the predicate evaluators.
The UUID branch accepted several input forms via UuidUtils.toBytes(Object), which was inconsistent with every other branch -- they each cast to one type. The input is in fact deterministic. GroupByDataTableReducer runs every column through ColumnDataType#convert immediately before calling isMatch, and convert returns UuidUtils.toUUID(...) for UUID, so the value is always a java.util.UUID. The other reduce path cannot deliver a UUID here at all: getConvertedKey has no UUID case and throws for it. Adds testHavingFilterOnUuidColumn, which pins the contract -- this line was previously untested in either direction. Verified it reaches the UUID branch rather than passing vacuously.
Part 5/8 of splitting apache#18140 (logical UUID type). Rebased onto latest master; stacked on uuid-split/04-sse-predicates-cast. Downstream references use the UuidKey class merged in apache#18869.
Part 6/8 of splitting apache#18140 (logical UUID type). Rebased onto latest master; stacked on uuid-split/05-agg-groupby-distinct. Downstream references use the UuidKey class merged in apache#18869.
xiangfu0
force-pushed
the
uuid-split/06-mse-planner-runtime
branch
from
August 8, 2026 09:36
7c23307 to
f5ffcae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent tracking issue: #16619
What
Multi-stage (v2) engine support for UUID.
Changes
expressions.protoUUID / UUID_ARRAY enum values + planner type resolution, Rex parsing, proto serde,TypeFactoryHashJoinOperator/EnrichedHashJoinOperator+UuidLookupTable(LookupTable.normalizeKey),OneUuidKeyGroupIdGenerator,ServerPlanRequestUtilsEnables
UUID equi-joins and group-by in the multi-stage engine.
Depends on
#18869 and #18871.
About this PR / how to review
This is part 6 of 8 splitting #18140 (first-class logical
UUIDtype) into layered PRs, as requested there.The split is enabled by the v1 design:
DataType.UUIDhas stored typeBYTES, so most paths handle it automatically; each PR adds explicit UUID semantics to one subsystem. Head branch lives onxiangfu0/pinot.This PR is stacked on #18873 (branch
uuid-split/05-agg-groupby-distinct). Because GitHub PRs to apache must base onmaster, the Files-changed tab is cumulative (it includes layers 1–6) until the PRs below it merge. Review the commit titled[UUID 6/8] UUID multi-stage engine (planner + runtime)— that is this layer's change. Each parent merge shrinks this diff after a rebase.Full stack (merge bottom → top)
After #18869 lands, PRs 2/4/7 (#18870, #18872, #18875) only depend on it and can be reviewed in parallel; PRs 5/6 (#18873, #18874) also need #18871; PR 8 (#18876) needs #18874.
Full feature description, v1 design contract, scope exclusions, and benchmark numbers: #18140.