[UUID 5/8] UUID aggregation, group-by and distinct - #18873
Open
xiangfu0 wants to merge 3 commits into
Open
Conversation
This was referenced Jun 29, 2026
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
3 times, most recently
from
June 30, 2026 09:14
6120bc9 to
478757f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18873 +/- ##
=============================================
- Coverage 66.65% 38.85% -27.80%
+ Complexity 1423 1416 -7
=============================================
Files 3443 3444 +1
Lines 218632 218904 +272
Branches 34793 34872 +79
=============================================
- Hits 145726 85061 -60665
- Misses 61192 126085 +64893
+ Partials 11714 7758 -3956
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
7 times, most recently
from
July 7, 2026 07:08
b5e8bc6 to
64cb941
Compare
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
11 times, most recently
from
July 14, 2026 08:03
ab8f6a0 to
adf9c85
Compare
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
10 times, most recently
from
July 21, 2026 08:10
47f5a6d to
6e5e246
Compare
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
3 times, most recently
from
July 27, 2026 00:20
5dbed17 to
474fae5
Compare
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
from
July 28, 2026 08:02
474fae5 to
ac891db
Compare
28 tasks
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
6 times, most recently
from
August 7, 2026 09:28
3db5958 to
364e42a
Compare
Adds UUID handling to the predicate evaluators, so =, !=, IN, NOT IN and range predicates work against a UUID column on both the raw and the dictionary path. UUID follows the pattern TIMESTAMP already uses: a logical type whose stored type does the work. The literal is parsed to its 16-byte stored form once, when the evaluator is built, and from there the existing BYTES evaluators apply -- no per-value conversion in the scan loop. The dictionary path needs no UUID branch: Dictionary#getStoredValue returns hex for a UUID column and indexOf(String) hex-decodes, so the existing String-keyed lookup is already correct. PredicateUtils renders the literal to that hex form for those String-typed lookup APIs. Split into apache#19181 (CAST), apache#19182 (bloom filter pruning) and apache#19183 (transform functions); this PR is now just the predicate evaluators.
The UUID branch accepted several input forms via UuidUtils.toBytes(Object), which was inconsistent with every other branch -- they each cast to one type. The input is in fact deterministic. GroupByDataTableReducer runs every column through ColumnDataType#convert immediately before calling isMatch, and convert returns UuidUtils.toUUID(...) for UUID, so the value is always a java.util.UUID. The other reduce path cannot deliver a UUID here at all: getConvertedKey has no UUID case and throws for it. Adds testHavingFilterOnUuidColumn, which pins the contract -- this line was previously untested in either direction. Verified it reaches the UUID branch rather than passing vacuously.
Part 5/8 of splitting apache#18140 (logical UUID type). Rebased onto latest master; stacked on uuid-split/04-sse-predicates-cast. Downstream references use the UuidKey class merged in apache#18869.
xiangfu0
force-pushed
the
uuid-split/05-agg-groupby-distinct
branch
from
August 8, 2026 09:36
364e42a to
2645a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent tracking issue: #16619
What
UUID-aware aggregation and grouping.
Changes
DISTINCTCOUNT,DISTINCTCOUNTHLL/HLLPLUS/THETASKETCH/CPCSKETCH/ULL/BITMAP,IntegerTupleSketch,ANY_VALUEUuidToIdMap,BytesDistinctTable,NonScanBasedAggregationOperatorEnables
GROUP BY uuidCol,DISTINCT uuidCol,DISTINCTCOUNT*(uuidCol).Depends on
#18869 and #18871 (
ColumnDataType.UUID).About this PR / how to review
This is part 5 of 8 splitting #18140 (first-class logical
UUIDtype) into layered PRs, as requested there.The split is enabled by the v1 design:
DataType.UUIDhas stored typeBYTES, so most paths handle it automatically; each PR adds explicit UUID semantics to one subsystem. Head branch lives onxiangfu0/pinot.This PR is stacked on #18872 (branch
uuid-split/04-sse-predicates-cast). Because GitHub PRs to apache must base onmaster, the Files-changed tab is cumulative (it includes layers 1–5) until the PRs below it merge. Review the commit titled[UUID 5/8] UUID aggregation, group-by and distinct— that is this layer's change. Each parent merge shrinks this diff after a rebase.Full stack (merge bottom → top)
After #18869 lands, PRs 2/4/7 (#18870, #18872, #18875) only depend on it and can be reviewed in parallel; PRs 5/6 (#18873, #18874) also need #18871; PR 8 (#18876) needs #18874.
Full feature description, v1 design contract, scope exclusions, and benchmark numbers: #18140.