Skip to content

sched/wqueue: Skip tick read for immediate work #21036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anchao wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

sched/wqueue: Skip tick read for immediate work #21036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sched/wqueue/kwork_queue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ static int work_qqueue(FAR struct kwork_wqueue_s *wqueue,

/* Preserve regular queue timing across lock contention. */

if (!period)
if (!period && delay > 0)

@casaroli casaroli Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With delay 0, qtime now stays 0. work_queue_next() adds the period to the old qtime (line 115), so a work queued with delay 0 that re-arms with work_queue_next() (sim_rptun.c:500/452, sim_rpmsg_virtio.c:251/188) runs back to back until it catches up with the current tick.

Fix: keep setting qtime to the current tick for delay 0, as libs/libc/wqueue/work_queue.c:124 does.

{
expected = clock_delay2abstick(delay);
}
Expand Down
Loading