Repository navigation
Conversation
Avoid calculating an absolute expiration time for immediate work items because they are queued directly on the expired list and do not use the pending timer ordering. Signed-off-by: chao an <anchao.archer@bytedance.com>
xiaoxiang781216
approved these changes
Oct 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid calculating an absolute expiration time for immediate workqueue items.
For regular workqueue submissions,
work_qqueue()used to callclock_delay2abstick(delay)even whendelay == 0. Immediate work items arequeued directly to the expired list and do not use pending timer ordering, so
the current system tick read is unnecessary in that path.
This change only computes the absolute expiration time when the work item is a
non-periodic delayed work item (
delay > 0).Benefits
clock_systime_ticks()read for immediate work itemswork_queue_next()behavior unchangedTesting
sim/nsh