Skip to content

[MDEP-971] Remove deprecated dependency:sources goal #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilx wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −66
Open

[MDEP-971] Remove deprecated dependency:sources goal #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/it-harness-poms/mdep-66/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ under the License.
<id>compile-sources</id>
<phase>generate-sources</phase>
<goals>
<goal>sources</goal>
<goal>resolve-sources</goal>
</goals>
<configuration>
<includeScope>compile</includeScope>
Expand All @@ -60,7 +60,7 @@ under the License.
<id>test-sources</id>
<phase>generate-sources</phase>
<goals>
<goal>sources</goal>
<goal>resolve-sources</goal>
</goals>
<configuration>
<includeScope>test</includeScope>
Expand Down
60 changes: 0 additions & 60 deletions ...n/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/site/markdown/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ The Dependency plugin has several goals:
- [dependency:resolve](./resolve-mojo.html) tells Maven to resolve all dependencies and displays the version. **JAVA 9 NOTE:** _will display the module name when running with Java 9._
- [dependency:resolve-plugins](./resolve-plugins-mojo.html) tells Maven to resolve plugins and their dependencies.
- [dependency:resolve-sources](./resolve-sources-mojo.html) tells Maven to resolve all dependencies and their source attachments, and displays the version.
- [dependency:sources](./sources-mojo.html) has been deprecated for removal in favor of [dependency:resolve-sources](./resolve-sources-mojo.html).
- [dependency:tree](./tree-mojo.html) displays the dependency tree for this project.
- [dependency:unpack](./unpack-mojo.html) like copy but unpacks.
- [dependency:unpack-dependencies](./unpack-dependencies-mojo.html) like copy-dependencies but unpacks.
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/org/apache/maven/plugins/dependency/TestSkip.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
import org.apache.maven.plugins.dependency.fromDependencies.UnpackDependenciesMojo;
import org.apache.maven.plugins.dependency.resolvers.GoOfflineMojo;
import org.apache.maven.plugins.dependency.resolvers.ListMojo;
import org.apache.maven.plugins.dependency.resolvers.OldResolveDependencySourcesMojo;
import org.apache.maven.plugins.dependency.resolvers.ResolveDependenciesMojo;
import org.apache.maven.plugins.dependency.resolvers.ResolveDependencySourcesMojo;
import org.apache.maven.plugins.dependency.resolvers.ResolvePluginsMojo;
import org.apache.maven.plugins.dependency.tree.TreeMojo;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -173,9 +173,9 @@ void testSkipResolvePlugins(ResolvePluginsMojo mojo) throws Exception {
}

@Test
@InjectMojo(goal = "sources")
@InjectMojo(goal = "resolve-sources")
@MojoParameter(name = "skip", value = "true")
void testSkipSources(OldResolveDependencySourcesMojo mojo) throws Exception {
void testSkipResolveSources(ResolveDependencySourcesMojo mojo) throws Exception {
doTest(mojo);
}

Expand Down