[MDEP-971] Remove deprecated dependency:sources goal - #1689
Open
wilx wants to merge 1 commit into
Open
Conversation
Remove the deprecated sources alias and its mojo implementation. Update the documentation, skip coverage, and the legacy MDEP-66 harness to use resolve-sources. Fixes apache#1481.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependency:sourcesgoal and itsOldResolveDependencySourcesMojoimplementationdependency:resolve-sourcesThe generated plugin descriptor now exposes
resolve-sourceswithout the removedsourcesalias.Fixes #1481.
Compatibility
The project supports Maven 3.6.3 and Java 8. This change removes an entry point and introduces no new Maven APIs, constructors, methods, or runtime features.
Testing
mvn spotless:applymvn clean verifymvn clean verify -Prun-itson JDK 21: 435 unit tests passed with 1 existing skip; all 102 Invoker builds passedtarget/classes/META-INF/maven/plugin.xmlto confirm that it containsresolve-sourcesand notsourcesFollowing this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
No negative test was added solely to assert the absence of the removed goal; existing skip coverage was moved to
resolve-sources.mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.