Skip to content

HIVE-29065: Fix Dockerfile warnings - FromAsCasing and InvalidDefault… #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kokila-19 wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −14
Open

HIVE-29065: Fix Dockerfile warnings - FromAsCasing and InvalidDefault… #6332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker-GA-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ jobs:
echo "HIVE_VERSION=${{ github.event.inputs.hiveVersion }}" >> $GITHUB_ENV
echo "HADOOP_VERSION=${{ github.event.inputs.hadoopVersion }}" >> $GITHUB_ENV
echo "TEZ_VERSION=${{ github.event.inputs.tezVersion }}" >> $GITHUB_ENV
echo "BUILD_ENV=archive" >> $GITHUB_ENV
echo "BUILD_ENV=release" >> $GITHUB_ENV

- name: Prepare environment variables for Release
if: github.event_name == 'create' && github.event.ref_type == 'tag' && startsWith(github.event.ref, 'rel/')
run: |
echo "HIVE_VERSION=$(mvn -f "pom.xml" -q help:evaluate -Dexpression=project.version -DforceStdout)" >> $GITHUB_ENV
echo "HADOOP_VERSION=$(mvn -f "pom.xml" -q help:evaluate -Dexpression=hadoop.version -DforceStdout)" >> $GITHUB_ENV
echo "TEZ_VERSION=$(mvn -f "pom.xml" -q help:evaluate -Dexpression=tez.version -DforceStdout)" >> $GITHUB_ENV
echo "BUILD_ENV=buildarchive" >> $GITHUB_ENV
echo "BUILD_ENV=hybrid" >> $GITHUB_ENV

- name: Prepare common environment variables
run: |
Expand Down
10 changes: 5 additions & 5 deletions packaging/src/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
ARG BUILD_ENV
ARG BUILD_ENV=local

FROM ubuntu as unarchive
FROM ubuntu AS local
ONBUILD COPY hadoop-*.tar.gz /opt
ONBUILD COPY apache-hive-*-bin.tar.gz /opt
ONBUILD COPY apache-tez-*-bin.tar.gz /opt

FROM ubuntu as archive
FROM ubuntu AS release
ARG HADOOP_VERSION
ARG HIVE_VERSION
ARG TEZ_VERSION
Expand All @@ -33,7 +33,7 @@ ONBUILD RUN mv /apache-tez-$TEZ_VERSION-bin.tar.gz /opt && \
mv hadoop-$HADOOP_VERSION.tar.gz /opt && \
mv apache-hive-$HIVE_VERSION-bin.tar.gz /opt

FROM ubuntu as buildarchive
FROM ubuntu AS hybrid
ARG HADOOP_VERSION
ARG HIVE_VERSION
ARG TEZ_VERSION
Expand All @@ -44,7 +44,7 @@ ONBUILD COPY ./apache-hive-$HIVE_VERSION-bin.tar.gz /opt
ONBUILD RUN mv /apache-tez-$TEZ_VERSION-bin.tar.gz /opt && \
mv hadoop-$HADOOP_VERSION.tar.gz /opt

FROM ${BUILD_ENV} as env
FROM ${BUILD_ENV} AS env
RUN echo ${BUILD_ENV}
ARG HADOOP_VERSION
ARG HIVE_VERSION
Expand Down
1 change: 0 additions & 1 deletion packaging/src/docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ docker build \
"$WORK_DIR" \
-f "$WORK_DIR/Dockerfile" \
-t "$repo/hive:$HIVE_VERSION" \
--build-arg "BUILD_ENV=unarchive" \
--build-arg "HIVE_VERSION=$HIVE_VERSION" \
--build-arg "HADOOP_VERSION=$HADOOP_VERSION" \
--build-arg "TEZ_VERSION=$TEZ_VERSION" \
Expand Down
10 changes: 5 additions & 5 deletions standalone-metastore/packaging/src/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
ARG BUILD_ENV
ARG BUILD_ENV=local

FROM ubuntu as unarchive
FROM ubuntu AS local
ONBUILD COPY hadoop-*.tar.gz /opt
ONBUILD COPY hive-standalone-metastore-*-bin.tar.gz /opt

FROM ubuntu as archive
FROM ubuntu AS release
ARG HADOOP_VERSION
ARG HIVE_VERSION
ONBUILD RUN apt-get update && apt-get -y install wget
Expand All @@ -29,15 +29,15 @@ ONBUILD RUN wget --no-verbose https://archive.apache.org/dist/hadoop/core/hadoop
ONBUILD RUN mv hadoop-$HADOOP_VERSION.tar.gz /opt && \
mv hive-standalone-metastore-$HIVE_VERSION-bin.tar.gz /opt

FROM ubuntu as buildarchive
FROM ubuntu AS hybrid
ARG HADOOP_VERSION
ARG HIVE_VERSION
ONBUILD RUN apt-get update && apt-get -y install wget
ONBUILD RUN wget --no-verbose https://archive.apache.org/dist/hadoop/core/hadoop-$HADOOP_VERSION/hadoop-$HADOOP_VERSION.tar.gz
ONBUILD COPY ./hive-standalone-metastore-$HIVE_VERSION-bin.tar.gz /opt
ONBUILD RUN mv hadoop-$HADOOP_VERSION.tar.gz /opt

FROM ${BUILD_ENV} as env
FROM ${BUILD_ENV} AS env
RUN echo ${BUILD_ENV}
ARG HADOOP_VERSION
ARG HIVE_VERSION
Expand Down
1 change: 0 additions & 1 deletion standalone-metastore/packaging/src/docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ docker build \
"$WORK_DIR" \
-f "$WORK_DIR/Dockerfile" \
-t "$repo/hive:standalone-metastore-$HIVE_VERSION" \
--build-arg "BUILD_ENV=unarchive" \
--build-arg "HIVE_VERSION=$HIVE_VERSION" \
--build-arg "HADOOP_VERSION=$HADOOP_VERSION" \

Expand Down