HIVE-29065: Fix Dockerfile warnings - FromAsCasing and InvalidDefault…#6332
Open
kokila-19 wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29065: Fix Dockerfile warnings - FromAsCasing and InvalidDefault…#6332kokila-19 wants to merge 1 commit intoapache:masterfrom
kokila-19 wants to merge 1 commit intoapache:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…ArgInFrom
What changes were proposed in this pull request?
In the Dockerfile, Match the case for all keywords (UPPER CASE).
Default value for BUILD_ENV argument. "FROM" determines the base image for the build and arg BUILD_ENV is used here. If it is empty/invalid , the image will not be created. So docker lint checks for this issue. To avoid it, a default value needs to set.
Why are the changes needed?
To remove the warnings thrown during docker build.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Create the docker image using build script for both hive and hms image.
./build.sh