Repository navigation
Stop requiring microbenchmark tests (amd64) check - #26811
Merged
Merged
Conversation
Prerequisite for apache#26766, which removes the job. Branch protection is read from .asf.yaml on main, so the required check must be dropped before the job is removed, otherwise apache#26766 waits forever for a check that never runs.
alamb
approved these changes
Oct 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 27, 2026
Sruhvx-jpg
pushed a commit
to Sruhvx-jpg/datafusion
that referenced
this pull request
Oct 28, 2026
## Which issue does this PR close? - Follow up to apache#25836 [comment](apache#25836 (comment)) ## Rationale for this change The required `microbenchmark tests (amd64)` job consumes approximately 10 runner minutes per merge-queue run. This recurring cost is not justified under the current maintainer resource constraints. This PR moves full microbenchmark health checks to local-only execution, eliminating their automatic CI cost and merge requirement. Runtime-only failures may remain undetected until a contributor explicitly runs the benchmarks. ## What changes are included in this PR? - Remove the microbenchmark job from `.github/workflows/extended.yml`, including automatic execution on merge groups and release pushes. - Depends on apache#26811, which removes `microbenchmark tests (amd64)` from the required checks in `.asf.yaml`. That must merge first: branch protection is read from `main`, so this PR stays blocked on the removed check until then. - Retain the existing local `cargo xtask ci step test microbenchmarks` command and its execution semantics without introducing a dedicated hosted workflow. - Update the contributor guide with local execution instructions, expectations for benchmark-related PRs, and the accepted risk of delayed runtime-failure detection. ## What is the testing strategy for this PR? No new automated tests are included. This change modifies CI configuration and documentation without changing the benchmark implementation. Existing Clippy checks retain benchmark compilation coverage, while the full benchmark health-check command remains available locally. The patch does not establish that the required-check validator, local benchmark command, documentation formatting checks, or affected workflow-policy tests have been run. Merge-queue behavior must also be verified after merge. ## Are there any user-facing changes? No changes to DataFusion's public APIs or query behavior. For contributors and maintainers, full microbenchmark health checks are no longer automatically executed or required for merging. They must be run locally using: ```shell cargo xtask ci step test microbenchmarks ``` No dedicated GitHub Actions workflow is provided. The contributor documentation has been updated accordingly. ## LLM-generated code disclosure This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
#26766 removes the
microbenchmark tests (amd64)job. Branch protection is read from.asf.yamlonmain, so while that check is still listed as required, #26766 isBLOCKEDwaiting for a check that no longer exists. Dropping the requirement first, in its own PR, breaks the deadlock.What changes are included in this PR?
microbenchmark tests (amd64)fromrequired_status_checksin.asf.yaml. The job itself is unchanged and keeps running in the merge queue until Make full microbenchmark execution local-only #26766 lands.What is the testing strategy for this PR?
python ci/scripts/check_asf_yaml_status_checks.pypasses locally (36 required checks, all matching existing jobs).Are there any user-facing changes?
No.
LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.