Repository navigation
Make full microbenchmark execution local-only - #26766
Merged
Merged
Conversation
…cumentation - Isolated, manual-only execution in .github/workflows/microbenchmarks.yml. - Removed automatic job and required merge check. - Added policy tests; documented compilation coverage and no-owner rationale against daily runs.
- Updated test_rust_workflow_skips.py to properly validate skip and manual execution policies. - Ensured regression tests reflect current behavior of Rust workflow skip conditions.
- Remove the microbenchmark health checks workflow from .github/workflows - Update documentation to reflect local-only execution for microbenchmark health checks
kosiew
changed the title
github-actions
Bot
added
documentation
kosiew
marked this pull request as ready for review
October 26, 2026 11:41
alamb
approved these changes
Oct 26, 2026
- Shortened purpose and local-only rationale. - Kept release policy, runtime-failure warning, PR reporting guidance.
Contributor
Author
|
🚀 |
kosiew
enabled auto-merge
October 27, 2026 10:44
james-willis
pushed a commit
to james-willis/datafusion
that referenced
this pull request
Oct 27, 2026
## Which issue does this PR close? - Prerequisite for apache#26766 ## Rationale for this change apache#26766 removes the `microbenchmark tests (amd64)` job. Branch protection is read from `.asf.yaml` on `main`, so while that check is still listed as required, apache#26766 is `BLOCKED` waiting for a check that no longer exists. Dropping the requirement first, in its own PR, breaks the deadlock. ## What changes are included in this PR? - Remove `microbenchmark tests (amd64)` from `required_status_checks` in `.asf.yaml`. The job itself is unchanged and keeps running in the merge queue until apache#26766 lands. ## What is the testing strategy for this PR? `python ci/scripts/check_asf_yaml_status_checks.py` passes locally (36 required checks, all matching existing jobs). ## Are there any user-facing changes? No. ## LLM-generated code disclosure This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The required
microbenchmark tests (amd64)job consumes approximately 10 runner minutes per merge-queue run. This recurring cost is not justified under the current maintainer resource constraints.This PR moves full microbenchmark health checks to local-only execution, eliminating their automatic CI cost and merge requirement. Runtime-only failures may remain undetected until a contributor explicitly runs the benchmarks.
What changes are included in this PR?
.github/workflows/extended.yml, including automatic execution on merge groups and release pushes.microbenchmark tests (amd64)from the required checks in.asf.yaml. That must merge first: branch protection is read frommain, so this PR stays blocked on the removed check until then.cargo xtask ci step test microbenchmarkscommand and its execution semantics without introducing a dedicated hosted workflow.What is the testing strategy for this PR?
No new automated tests are included. This change modifies CI configuration and documentation without changing the benchmark implementation.
Existing Clippy checks retain benchmark compilation coverage, while the full benchmark health-check command remains available locally.
The patch does not establish that the required-check validator, local benchmark command, documentation formatting checks, or affected workflow-policy tests have been run. Merge-queue behavior must also be verified after merge.
Are there any user-facing changes?
No changes to DataFusion's public APIs or query behavior.
For contributors and maintainers, full microbenchmark health checks are no longer automatically executed or required for merging. They must be run locally using:
cargo xtask ci step test microbenchmarksNo dedicated GitHub Actions workflow is provided. The contributor documentation has been updated accordingly.
LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.