fix: make the sql feature truly optional (#20625)#20680
Open
comphead wants to merge 1 commit intoapache:branch-53from
Open
fix: make the sql feature truly optional (#20625)#20680comphead wants to merge 1 commit intoapache:branch-53from
sql feature truly optional (#20625)#20680comphead wants to merge 1 commit intoapache:branch-53from
Conversation
## Which issue does this PR close? N/A ## Rationale for this change When enabling the `recursive_protection` feature for the `datafusion` crate, the `sql` feature is enabled. This is undesirable if the downstream project would like the `sql` feature to be off. ## What changes are included in this PR? Use the `?` syntax for features of dependencies for `recursive_protection`. This was already correctly done for other features such as `unicode_expressions`. <https://doc.rust-lang.org/cargo/reference/features.html> ## Are these changes tested? N/A ## Are there any user-facing changes? This makes dependency management better for downstream projects and is not a breaking change.
Jefffrey
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Backport for #20625
When enabling the
recursive_protectionfeature for thedatafusioncrate, thesqlfeature is enabled. This is undesirable if the downstream project would like thesqlfeature to be off.What changes are included in this PR?
Use the
?syntax for features of dependencies forrecursive_protection. This was already correctly done for other features such asunicode_expressions.https://doc.rust-lang.org/cargo/reference/features.html
Are these changes tested?
N/A
Are there any user-facing changes?
This makes dependency management better for downstream projects and is not a breaking change.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?