fix: make the sql feature truly optional#20625
Merged
adriangb merged 1 commit intoapache:mainfrom Mar 3, 2026
Merged
Conversation
Jefffrey
approved these changes
Mar 2, 2026
26 tasks
adriangb
approved these changes
Mar 3, 2026
Contributor
|
@comphead could you cherry pick this into the 53 branch? |
Contributor
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Mar 3, 2026
## Which issue does this PR close? N/A ## Rationale for this change When enabling the `recursive_protection` feature for the `datafusion` crate, the `sql` feature is enabled. This is undesirable if the downstream project would like the `sql` feature to be off. ## What changes are included in this PR? Use the `?` syntax for features of dependencies for `recursive_protection`. This was already correctly done for other features such as `unicode_expressions`. <https://doc.rust-lang.org/cargo/reference/features.html> ## Are these changes tested? N/A ## Are there any user-facing changes? This makes dependency management better for downstream projects and is not a breaking change.
alamb
pushed a commit
that referenced
this pull request
Mar 4, 2026
## Which issue does this PR close? N/A ## Rationale for this change Backport for #20625 When enabling the `recursive_protection` feature for the `datafusion` crate, the `sql` feature is enabled. This is undesirable if the downstream project would like the `sql` feature to be off. ## What changes are included in this PR? Use the `?` syntax for features of dependencies for `recursive_protection`. This was already correctly done for other features such as `unicode_expressions`. <https://doc.rust-lang.org/cargo/reference/features.html> ## Are these changes tested? N/A ## Are there any user-facing changes? This makes dependency management better for downstream projects and is not a breaking change. ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> Co-authored-by: Heran Lin <heran@lakesail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
When enabling the
recursive_protectionfeature for thedatafusioncrate, thesqlfeature is enabled. This is undesirable if the downstream project would like thesqlfeature to be off.What changes are included in this PR?
Use the
?syntax for features of dependencies forrecursive_protection. This was already correctly done for other features such asunicode_expressions.https://doc.rust-lang.org/cargo/reference/features.html
Are these changes tested?
N/A
Are there any user-facing changes?
This makes dependency management better for downstream projects and is not a breaking change.