Skip to content

refactor: Spark ascii signature away from user_defined #19513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumarUjjawal wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −6
Open

refactor: Spark ascii signature away from user_defined #19513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions datafusion/spark/src/function/string/ascii.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@

use arrow::datatypes::DataType;
use datafusion_common::Result;
use datafusion_common::types::{NativeType, logical_string};
use datafusion_expr::ColumnarValue;
use datafusion_expr::{ScalarFunctionArgs, ScalarUDFImpl, Signature, Volatility};
use datafusion_expr::{
Coercion, ScalarFunctionArgs, ScalarUDFImpl, Signature, TypeSignatureClass,
Volatility,
};
use datafusion_functions::string::ascii::ascii;
use datafusion_functions::utils::make_scalar_function;
use std::any::Any;
Expand All @@ -42,8 +46,17 @@ impl Default for SparkAscii {

impl SparkAscii {
pub fn new() -> Self {
// Spark's ascii uses ImplicitCastInputTypes with StringType,
// which allows numeric types to be implicitly cast to String.
// See: https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
let string_coercion = Coercion::new_implicit(
TypeSignatureClass::Native(logical_string()),
vec![TypeSignatureClass::Numeric],
NativeType::String,
);

Self {
signature: Signature::user_defined(Volatility::Immutable),
signature: Signature::coercible(vec![string_coercion], Volatility::Immutable),
}
}
}
Expand All @@ -68,8 +81,4 @@ impl ScalarUDFImpl for SparkAscii {
fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> {
make_scalar_function(ascii, vec![])(&args.args)
}

fn coerce_types(&self, _arg_types: &[DataType]) -> Result<Vec<DataType>> {
Ok(vec![DataType::Utf8])
}
}