Skip to content

refactor: Spark ascii signature away from user_defined #19513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kumarUjjawal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Spark ascii signature away from user_defined #19513

kumarUjjawal wants to merge 1 commit into from
+15 −6

Conversation

@kumarUjjawal
Copy link
Contributor

@kumarUjjawal kumarUjjawal commented Dec 27, 2025 •
edited by Jefffrey
Loading

Which issue does this PR close?

Rationale for this change

As per the goal stated that we should avoid using the user_defined in useful places.

What changes are included in this PR?

  • Refactored Spark ascii to not use user_defined.
  • Checked the Spark code to make sure it follows the same convention

Are these changes tested?

  • This is a refactoring so no new tests were added but all previous test pass.

Are there any user-facing changes?

@github-actions github-actions bot added the spark label Dec 27, 2025
@Jefffrey Jefffrey mentioned this pull request Dec 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees

No one assigned

Labels

spark

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumarUjjawal @Jefffrey