Skip to content

Warn on failed import of internal BQ client for easier debugging #40082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrmccluskey wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

Warn on failed import of internal BQ client for easier debugging #40082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdks/python/apache_beam/io/gcp/internal/clients/bigquery/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"""Common imports for generated bigquery client library."""
# pylint:disable=wildcard-import

import logging
import pkgutil

# Protect against environments where apitools library is not available.
Expand All @@ -28,6 +29,9 @@
from apache_beam.io.gcp.internal.clients.bigquery.bigquery_v2_client import *
from apache_beam.io.gcp.internal.clients.bigquery.bigquery_v2_messages import *
except ImportError:
logging.warning(
"apitools not found, and bigquery client libraries are not "
"available despite the import not raising an ImportError.")

@damccorm damccorm Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal world we'd just throw the exception. I guess this is going away soon anyways, though, so this is probably fine

pass
# pylint: enable=wrong-import-order, wrong-import-position

Expand Down
Loading