Skip to content

Warn on failed import of internal BQ client for easier debugging - #40082

Open
jrmccluskey wants to merge 1 commit into
apache:masterfrom
jrmccluskey:internalImport
Open

Warn on failed import of internal BQ client for easier debugging#40082
jrmccluskey wants to merge 1 commit into
apache:masterfrom
jrmccluskey:internalImport

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Imports of the internal BQ client fail if the GCP extras category is not installed; however, the init.py file for the internal client was written to swallow ImportErrors. This made it hard to debug unit tests that carry that dependency, as the import of the package would silently fail and underlying types would not be available to use.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

except ImportError:
logging.warning(
"apitools not found, and bigquery client libraries are not "
"available despite the import not raising an ImportError.")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal world we'd just throw the exception. I guess this is going away soon anyways, though, so this is probably fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants