Skip to content

GH-50308: [C++][IPC] Add input size validation to SparseCSFIndex::Make #50480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connorsimms wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −0
Open

GH-50308: [C++][IPC] Add input size validation to SparseCSFIndex::Make #50480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions cpp/src/arrow/sparse_tensor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,21 @@ Result<std::shared_ptr<SparseCSFIndex>> SparseCSFIndex::Make(
const std::vector<std::shared_ptr<Buffer>>& indptr_data,
const std::vector<std::shared_ptr<Buffer>>& indices_data) {
int64_t ndim = axis_order.size();

// Validate input dimensions before accessing buffers
if (ndim == 0) {
return Status::Invalid("axis_order cannot be empty");
}
if (indices_shapes.size() != static_cast<size_t>(ndim)) {
return Status::Invalid("indices_shapes must have the same size as axis_order");
}
if (indptr_data.size() != static_cast<size_t>(ndim - 1)) {
return Status::Invalid("indptr_data must have size equal to ndim - 1");
}
if (indices_data.size() != static_cast<size_t>(ndim)) {
return Status::Invalid("indices_data must have the same size as axis_order");
}

std::vector<std::shared_ptr<Tensor>> indptr(ndim - 1);
std::vector<std::shared_ptr<Tensor>> indices(ndim);

Expand Down
23 changes: 23 additions & 0 deletions cpp/src/arrow/sparse_tensor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1698,4 +1698,27 @@ TEST(TestSparseCSFMatrixForUInt64Index, Make) {
ASSERT_RAISES(Invalid, SparseCSFTensor::Make(dense_tensor, uint64()));
}

TEST(TestSparseCSFIndex, Make) {
std::vector<int64_t> axis_order = {0, 1, 2};
std::vector<int64_t> indices_shapes = {5, 5, 5};
std::vector<std::shared_ptr<Buffer>> indptr_data(2);
std::vector<std::shared_ptr<Buffer>> indices_data(3);

// Invalid indices_shapes size
ASSERT_RAISES(Invalid, SparseCSFIndex::Make(int32(), int32(), {5}, axis_order,
indptr_data, indices_data));

// Empty axis order
ASSERT_RAISES(Invalid, SparseCSFIndex::Make(int32(), int32(), indices_shapes, {},
indptr_data, indices_data));

// Invalid indptr_data size
ASSERT_RAISES(Invalid, SparseCSFIndex::Make(int32(), int32(), indices_shapes,
axis_order, {}, indices_data));

// Invalid indices_data size
ASSERT_RAISES(Invalid, SparseCSFIndex::Make(int32(), int32(), indices_shapes,
axis_order, indptr_data, {}));
}

} // namespace arrow