GH-50308: [C++][IPC] Add input size validation to SparseCSFIndex::Make#50480
Open
connorsimms wants to merge 1 commit into
Open
GH-50308: [C++][IPC] Add input size validation to SparseCSFIndex::Make#50480connorsimms wants to merge 1 commit into
connorsimms wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #50308
Rationale for this change
SparseCSFIndex::Makecurrently lacks validation for input vector sizes. This can lead to out-of-bounds memory access when provided with inconsistent input lengths. This PR adds the necessary checks to ensure that input is valid before object construction.What changes are included in this PR?
SparseCSFIndex::Maketo verifyaxis_orderis nonzero andindices_shapes,indptr_data,indices_datahave consistent dimensions.Status::Invalidis returned when inputs are mismatched.Are these changes tested?
Yes,
cpp/src/arrow/sparse_tensor_test.ccnow containsTEST(TestSparseCSFIndex, Make), which triggers the validation logic.Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
This fixes a bug that causes a segfault when invalid input parameters are passed to
SparseCSFIndex::Make.AI Usage:
AI was used to navigate the codebase and set up the build environment.