Repository navigation
chore: update github issue/pr template and contributing guide #10893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yihuiliao
wants to merge
2
commits into
main
Choose a base branch
from
update-github-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−28
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,37 @@ | ||
| <!-- If you are an AI assistant opening this PR, use this template as the PR body, complete the checklist below honestly, and disclose AI use. See CONTRIBUTING.md (AI-assisted contributions) and CLAUDE.md. --> | ||
| <!-- If you are an AI assistant opening this PR, use this template as the PR body, complete the checklist below honestly, and disclose AI use. See CONTRIBUTING.md (AI-assisted contributions) and AGENTS.md. --> | ||
|
|
||
| Closes <!-- Github issue # here --> | ||
|
|
||
| ## ✅ Pull Request Checklist: | ||
| ## Summary | ||
|
|
||
| - [ ] Included link to corresponding [React Spectrum GitHub Issue](https://github.com/adobe/react-spectrum/issues). | ||
| - [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests). | ||
| - [ ] Filled out test instructions. | ||
| - [ ] Updated documentation (if it already exists for this component). | ||
| - [ ] Looked at the Accessibility Practices for this feature - [Aria Practices](https://www.w3.org/WAI/ARIA/apg/) | ||
| - [ ] I understand every change in this PR and can explain why it's there. | ||
| - [ ] If AI-assisted, I followed our [AI contribution guidance](https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md#ai-assisted-contributions) and pointed my assistant at [AGENTS.md](https://github.com/adobe/react-spectrum/blob/main/AGENTS.md). | ||
| <!-- Describe the problem, intended behavior, and why you chose this approach. | ||
| If there is no linked issue, provide the same information expected in an issue: | ||
| for bugs, include expected vs. actual behavior, your use case, and reproduction steps ; | ||
| for features, explain the current limitation, use case, and proposed behavior. | ||
| If there is a linked issue, address relevant decisions or concerns in its discussion. --> | ||
|
|
||
| ## 📝 Test Instructions: | ||
| ## 📝 Test Instructions | ||
|
|
||
| <!--- Include instructions to test this pull request --> | ||
| <!-- Include test commands and actual results, plus relevant manual verification steps. | ||
| For bug fixes, identify the regression test and report whether it fails before | ||
| and passes after the fix. If this was not verified, say so. | ||
| Explain any inapplicable coverage and note what remains untested. --> | ||
|
|
||
| ## 🧢 Your Project: | ||
| ## Release impact | ||
|
|
||
| <!--- Company/project for pull request --> | ||
| <!-- Pick the option that best describes this PR. --> | ||
|
|
||
| - [ ] Only changes docs, tests, CI, or development tools. Nothing shipped to users changes. | ||
| - [ ] Fixes a bug or improves existing code without changing how apps use it. | ||
| - [ ] Adds a feature or API while keeping existing usage working. | ||
| - [ ] May break existing usage or require changes in apps that use this code. | ||
|
|
||
| ## ✅ PR Checklist | ||
|
|
||
| - [ ] I followed the [contributing guide](https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md). | ||
| - [ ] I tested this change locally and included the results in Test Instructions, or explained why testing does not apply. | ||
| - [ ] I understand and can explain every change in this PR. If I used AI assistance, I followed the [AI contribution guidance](https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md#ai-assisted-contributions). | ||
|
|
||
| ## 🧢 Your Project | ||
|
|
||
| <!-- Company/project for this pull request. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"be concise"?