Skip to content

DX-1128: localise interactive components (SegmentedControl, TabMenu)#3413

Draft
jamiehenson wants to merge 1 commit into
dx-1128/docs-components-presentationalfrom
dx-1128/docs-components-interactive
Draft

DX-1128: localise interactive components (SegmentedControl, TabMenu)#3413
jamiehenson wants to merge 1 commit into
dx-1128/docs-components-presentationalfrom
dx-1128/docs-components-interactive

Conversation

@jamiehenson

@jamiehenson jamiehenson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Part of DX-1128. Localises the interactive components.

What

src/components/ui/SegmentedControl.tsx + TabMenu.tsx, vendored and rewired to local Icon/cn (es-toolkit direct dep).

Behaviour

No visual change intended.

Stack (DX-1128)

PR Role
#3409 Design foundation — vendor @ably/ui tokens + reset/core CSS
#3410 Local cn + heights utils
#3411 Docs-native Icon component
#3412 Presentational components (Badge, Button, LinkButton, FeaturedLink, Status)
#3413 Interactive components (SegmentedControl, TabMenu)
#3414 ProductTile + product data (leaf)
#3415 syntax-highlighter util + registry
#3416 Code + CodeSnippet — completes the lift; prunes dead CSS + drops @ably/ui Tailwind scan
#3417 Combined view of #3409#3416 — review/demo only (based on main)

#3409#3416 are a linear stack (each builds on the previous); #3417 is the combined view. ▶ = this PR.

Testing

  • Load the review app.
  • Check a sufficient sample of pages load with no visual regressions.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4797b42a-151b-4168-a799-b210f894895f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dx-1128/docs-components-interactive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from ef72e03 to 02d982a Compare June 18, 2026 13:18
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from c57d361 to eb5a063 Compare June 18, 2026 13:18
@jamiehenson jamiehenson marked this pull request as ready for review June 18, 2026 13:36
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from 02d982a to a74f1b6 Compare June 18, 2026 14:34
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from eb5a063 to 6f2cac7 Compare June 18, 2026 14:34
@jamiehenson jamiehenson added the review-app Create a Heroku review app label Jun 18, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 18, 2026 14:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from a74f1b6 to e801746 Compare June 18, 2026 14:57
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 6f2cac7 to e11ceaf Compare June 18, 2026 14:57
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 18, 2026 14:57 Inactive
Vendor SegmentedControl and TabMenu into src/components/ui/, adapted to the
local cn / Icon / colors (DX-1128). es-toolkit promoted to a direct dependency
(TabMenu's throttle; was transitive); @radix-ui/react-tabs is already a docs
dep. 2 consumer import sites codemodded. eslint clean.

Refs: DX-1128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

2 participants