DX-1128: localise presentational components (Badge/Button/LinkButton/FeaturedLink/Status)#3412
Draft
jamiehenson wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiehenson
force-pushed
the
dx-1128/docs-local-icon
branch
from
4c74691 to
8b2ecc6
Compare
jamiehenson
force-pushed
the
dx-1128/docs-components-presentational
branch
from
ef72e03 to
02d982a
Compare
jamiehenson
force-pushed
the
dx-1128/docs-local-icon
branch
from
8b2ecc6 to
5d78500
Compare
jamiehenson
force-pushed
the
dx-1128/docs-components-presentational
branch
from
02d982a to
a74f1b6
Compare
jamiehenson
force-pushed
the
dx-1128/docs-local-icon
branch
from
5d78500 to
7e2f701
Compare
jamiehenson
force-pushed
the
dx-1128/docs-components-presentational
branch
from
a74f1b6 to
e801746
Compare
Vendor Badge, Button, LinkButton, FeaturedLink and Status into src/components/ui/, owned locally and adapted to the local cn / Icon (DX-1128). Adds: - src/components/ui/colors.ts — local copy of @ably/ui's colour types + data (ColorClass / ColorThemeSet / ColorClassColorGroups), shared by these components (and the rest of the lift). - IconSize to the local Icon types. - src/images/ably-logo.svg (used as a URL by the header). - swr as a direct dependency (Status fetches system status; was transitive). All @ably/ui imports in the vendored components are repointed to local paths; ~12 consumer import sites codemodded off @ably/ui/core/*. eslint clean. Refs: DX-1128
jamiehenson
force-pushed
the
dx-1128/docs-local-icon
branch
from
7e2f701 to
0fa1f37
Compare
jamiehenson
force-pushed
the
dx-1128/docs-components-presentational
branch
from
e801746 to
cee3a61
Compare
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DX-1128. Localises the presentational components docs uses from
@ably/ui.What
Vendored into
src/components/ui/(rewired to local Icon/cn/colors):Badge,Button,LinkButton,FeaturedLink,Status, pluscolors.tsand the Ably logo SVG.swrpromoted to a direct dep.Behaviour
No visual change intended — vendored from the
@ably/uisource, rewired to local primitives.Stack (DX-1128)
@ably/uitokens + reset/core CSScn+heightsutilsIconcomponent@ably/uiTailwind scanmain)#3409–#3416 are a linear stack (each builds on the previous); #3417 is the combined view. ▶ = this PR.
Testing
🤖 Generated with Claude Code