Fix/ffvii rebirth - #6
Merged
Merged
Conversation
The Linux build linked libexpat and read its drirc from /usr/local/share/drirc.d, which the WinNative rootfs does not have, so Turnip's vkd3d and DXVK options never applied: vkd3d-proton detected only Shader Model 6.0 unless VKD3D_SHADER_MODEL overrode it, and the D3D texture coordinate rounding and alpha-to-coverage emulation were off. Build with -Dxmlconfig=disabled, as the Android drivers are, and fail verification when a package reads its defaults from disk.
FINAL FANTASY VII REBIRTH draws its world with mesh shaders and creates compute shaders that declare WaveSize(32). Turnip had no VK_EXT_mesh_shader and no subgroup size below 64 on A8XX, so the game's pipelines failed. Apply two Mesa commits from linux/patches after the existing scripts: compute-based mesh shader emulation, and half-wave subgroups for a required subgroup size of 32. Verification fails when either is missing.
With mesh shaders and wave32 subgroups in place, the game still lost the device on A8XX, at the title or while loading gameplay. Add three Mesa commits to linux/patches: sanitize cube map sampling directions, invalidate bindless descriptors through A8XX's dedicated registers, and fetch command streams through a KGSL virtual BO alias that is unbound before the memory is freed. Refresh the mesh shader patch with its per-component output copy, and verify the new patches in the build.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.