Fix the Linux Turnip build and release - #7
Merged
Merged
Conversation
Upstream Mesa renamed the a7xx_gen1 quirks to QCTDD ids, so the exact-text anchor stopped matching and every build since has shipped A720/A725/A730 without the early preamble and scalar predicate overrides. Match the block itself, ending at its first unindented line, and set each override in place or add it, so renamed or upstream-set keys still apply.
The a7xx_gen1 skip above passed verification: the check only looked for each script's "done" line, which prints on every path. Fail on any WARNING or FATAL line in the patch stage. Deliberate skips such as the autotune drawcall gate print neither.
Mesa 1887e21 removed tu_has_multiview and moved the a8xx quirks into their own section, so 0001 and 0003 no longer applied. The code the patches add is unchanged.
The Linux workflow only ran for pushes to feature/linux-drivers, and main had two weekly schedulers after both branches merged. Build pushes to main, keep the workflow's own schedule, and drop the reusable-workflow scheduler. Push builds get their own concurrency group so they cannot cancel a pending release.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux Turnip build failed on current Mesa main and never ran from
main, so no Linux release was built after #6.1887e21. Upstream removedtu_has_multiviewand moved the a8xx quirks into their own section. The code the patches add is unchanged.apply_a7xx_gen1_quirks.pyon the wholea7xx_gen1block. Upstream renamed the quirks, so the script silently skipped, and the Android builds on main were missing the A720/A725/A730 overrides.verify_patches.shfail when a patch script prints WARNING or FATAL during the patch stage. That skip had passed the Android check.mainand drop the second scheduler that calledfeature/linux-drivers. Push builds get their own concurrency group so they can't cancel a pending release.Tested with a local build of both variants against Mesa
1887e21: all five patches apply and both packages verify. The gen1 script was tested on old and new Mesa layouts and edge cases, andverify_patches.shagainst the Android log from main.