Skip to content

[multibyte] Disable expanded array types until interpreter is ready. #8938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendandahl wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

[multibyte] Disable expanded array types until interpreter is ready. #8938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wasm/wasm-validator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3869,8 +3869,8 @@ void FunctionValidator::visitArraySet(ArraySet* curr) {
}

static bool isValidMultibyteElement(const Field& element) {
return element.packedType == Field::i8 || element.packedType == Field::i16 ||
(element.packedType == Field::NotPacked && element.type.isNumber());
// TODO: Expand once interpreter supports additional numeric types.
return element.packedType == Field::i8;

@kripken kripken Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to disable this feature in the fuzzer? See DISALLOWED_FEATURES_IN_V8 in scripts/fuzz_opt.py.

But I don't feel strongly if this PR is simpler for you.

}

void FunctionValidator::visitArrayLoad(ArrayLoad* curr) {
Expand Down
1 change: 1 addition & 0 deletions test/lit/array-multibyte.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
;; XFAIL: *
;; RUN: wasm-opt %s -all -S -o - | filecheck %s
;; RUN: wasm-opt %s -all --roundtrip -S -o - | filecheck %s --check-prefix=RTRIP

Expand Down
Loading