[multibyte] Disable expanded array types until interpreter is ready.#8938
Open
brendandahl wants to merge 1 commit into
Open
[multibyte] Disable expanded array types until interpreter is ready.#8938brendandahl wants to merge 1 commit into
brendandahl wants to merge 1 commit into
Conversation
Collaborator
Author
|
It may be a bit before I can land the interpreter support, so probably good to disable for now. |
kripken
reviewed
Jul 24, 2026
| return element.packedType == Field::i8 || element.packedType == Field::i16 || | ||
| (element.packedType == Field::NotPacked && element.type.isNumber()); | ||
| // TODO: Expand once interpreter supports additional numeric types. | ||
| return element.packedType == Field::i8; |
Member
There was a problem hiding this comment.
Another option is to disable this feature in the fuzzer? See DISALLOWED_FEATURES_IN_V8 in scripts/fuzz_opt.py.
But I don't feel strongly if this PR is simpler for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.