Skip to content

fix: handle null table container #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
biubiukam wants to merge 2 commits into
base: develop
Choose a base branch
from
+22 −1
Open

fix: handle null table container #5218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de71a06
fix: handle null table container
biubiukam Jul 13, 2026
3aba23b
docs: update changlog of rush
biubiukam Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vtable/fix-issue-5217-null-container_2026-07-13-13-10.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: handle null table container",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "biukam.w@gmail.com"
}
10 changes: 10 additions & 0 deletions packages/vtable/__tests__/options/listTable-null-container.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// @ts-nocheck
import { ListTable } from '../../src';

global.__VERSION__ = 'none';

describe('ListTable null container', () => {
test('throws a clear error when the container argument is null', () => {
expect(() => new ListTable(null, { columns: [] })).toThrow("vtable's container is undefined");
});
});
2 changes: 1 addition & 1 deletion packages/vtable/src/core/BaseTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export abstract class BaseTable extends EventTarget implements BaseTableAPI {
if (Env.mode === 'node') {
options = container as BaseTableConstructorOptions;
container = null;
} else if (!(container instanceof HTMLElement)) {
} else if (container && !(container instanceof HTMLElement)) {
options = container as BaseTableConstructorOptions;
if ((container as BaseTableConstructorOptions).container) {
container = (container as BaseTableConstructorOptions).container;
Expand Down
Loading