fix: handle null table container#5218
Open
biubiukam wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #5217
💡 Background and solution
When
ListTableis constructed with a null container,BaseTabletreats the first argument as constructor options and readscontainer.containerbefore the existing validation runs. This causes an unhandled null-reference error instead of the intended container validation error.This change only treats a truthy non-
HTMLElementfirst argument as the options overload. An explicit null container now reaches the existing validation and throwsvtable's container is undefined.A regression test covers the null-container constructor path.
Validation:
node common/scripts/install-run-rush.js run -p @visactor/vtable -s compilenode common/scripts/install-run-rush.js test --only tag:package📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough