Skip to content

CHANGE: Removing InputSystem icons from scene view window - #2480

Open
josepmariapujol-unity wants to merge 2 commits into
developfrom
input/uum-151780/icon-scene-view
Open

CHANGE: Removing InputSystem icons from scene view window#2480
josepmariapujol-unity wants to merge 2 commits into
developfrom
input/uum-151780/icon-scene-view

Conversation

@josepmariapujol-unity

@josepmariapujol-unity josepmariapujol-unity commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Description

Removing InputSystem icons from scene view window.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity changed the title Removing icons from scene view window CHANGE: Removing InputSystem icons from scene view window Sep 8, 2026
@josepmariapujol-unity josepmariapujol-unity self-assigned this Sep 8, 2026
@josepmariapujol-unity
josepmariapujol-unity marked this pull request as ready for review September 8, 2026 13:18

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The change adds editor icon metadata to the three targeted component types and records the Scene view icon update in the changelog. I examined the referenced assets, their importer metadata, and the package’s existing icon/gizmo assignment paths.

Reviewed commit 29b1085

🤖 Helpful? 👍/👎

@codecov-github-com

codecov-github-com Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff            @@
##           develop    #2480    +/-   ##
=========================================
  Coverage    78.95%   78.95%            
=========================================
  Files          767      767            
  Lines       140780   140907   +127     
=========================================
+ Hits        111153   111259   +106     
- Misses       29627    29648    +21     
Flag Coverage Δ
inputsystem_MacOS_6000.0 5.30% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.50% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.3 5.30% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.50% <ø> (+0.01%) ⬆️
inputsystem_MacOS_6000.5 5.29% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.56% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.6 5.29% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.6_project 77.56% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.7 5.29% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.7_project 77.56% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.0 5.31% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.40% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.31% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.40% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.5 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.46% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.6 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.6_project 77.46% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.7 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.7_project 77.46% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.0 5.30% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.63% <ø> (+0.06%) ⬆️
inputsystem_Windows_6000.3 5.30% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.62% <ø> (+0.06%) ⬆️
inputsystem_Windows_6000.5 5.29% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.68% <ø> (+0.06%) ⬆️
inputsystem_Windows_6000.6 5.29% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.6_project 77.69% <ø> (+0.06%) ⬆️
inputsystem_Windows_6000.7 5.29% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.7_project 77.68% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tSystem/Runtime/Plugins/PlayerInput/PlayerInput.cs 86.89% <ø> (ø)
.../Runtime/Plugins/PlayerInput/PlayerInputManager.cs 70.90% <ø> (ø)
...tem/Runtime/Plugins/UI/InputSystemUIInputModule.cs 93.11% <ø> (ø)

... and 4 files with indirect coverage changes

ℹ️ Need help interpreting these results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant