Repository navigation
[Util] Fix cached priority ordering after insertion - #538
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
peek()caches the best element,DeterministicPriorityCollection.add()compares a new priority in the wrong direction. A worse element can replace the cached best, while a better element remains behind it. This affects deterministic weighted path selectors when states are added after selection.Reverse that comparison so the cached element follows the same ordering as the underlying priority queue. Four regression tests cover better and worse insertions with natural and reverse comparators, and verify that the displaced element remains available.
Validation:
:usvm-util:check: 60 passed.:usvm-core:check: 253 passed, one existing skipped test.:usvm-sample-language:check: 12 passed.This is independent of #526 and does not change public APIs.