Repository navigation
[TS PBT] Retain original-property search across native coverage updates - #549
Closed
CaelmBleidd wants to merge 4 commits into
Closed
CaelmBleidd wants to merge 4 commits into
CaelmBleidd wants to merge 4 commits into
Conversation
Integrate exact core dependency 25f6634 while preserving the PBT path-selector factory and caller deadline in the retained analysis preparation and stop gate.
Keep the original manifest, projection, observers, pending queue and solver resources across bounded advances. Validate later native evidence against a pinned environment, invalidate changed source, and retain early counterexamples in partial results.
This was referenced Oct 16, 2026
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn on 2026-10-16
Cross-round retained property sessions are not needed for one PBT evidence phase followed by one USVM search. Do not merge the public session/late-PBT-update layer. The useful initial-report mapping fix has been detached from this branch as local commit
42dfc324don #524.The project owner changed scope; the authoritative plan is #345. This PR is closed without merging and does not establish completed delivery of the former task. Keep the historical experimental snapshots reproducible.
Repeated property searches previously rebuilt the symbolic analysis, losing its pending queue and completed work between native PBT runs.
UsvmPropertySearcher.openSession()now prepares the original manifest, mapping, domain projection, observer, queue and solver resources once.advance(maxSteps)continues that analysis, andapplyCoverage(nativeArtifact)updates the existing coverage selector without rebuilding the frontend or initial states.search()remains the one-shot wrapper. A yielded phase reportsIN_PROGRESS, retaining any already found candidate input and violation target. Partial unsupported paths keep their diagnostics while pending work continues. A valid initial admitted-native coverage report anchors later updates; stale, incompatible, unsupported and no-admission reports have explicit rejection outcomes. The manifest and native environment collections are snapshotted. A change to the current source invalidates the session and closes its resources, even if the source is subsequently restored. Coverage changes priorities only; it never adds path constraints or drops covered prefixes.This is the retained original-property session and native-coverage update slice of #481. Campaign scheduling and hypothesis transfer remain separate. Analysis-wide limits stay cumulative and a finished analysis stays finished.
The PR is stacked on #524 at
be0b569f6e8a1f7fe00665b29345d6fb11c94849. Its final head isc3ce550489f13b2200b406f77cde471bcb516552. The 22-file branch diff has three distinct parts:b29e7d07edb12d12b4dfd511efbb6d2cf1e3d5a0: 10 inherited string-model files, +461/-58. The [TS PBT] Guide original property search with admitted edge coverage #524/[TS] Reuse closest-to-uncovered NURS for external coverage #526 branch point predates that main commit.25f663469ad27929f41fe55146b8736762465210: three inherited files, +577/-73. It is integrated by a real merge with that exact second parent, not copied or cherry-picked. Merge resolution preserves [TS PBT] Guide original property search with admitted edge coverage #524's selector factory and caller deadline in the new helpers/stop gate and shares the two identical finished-analysis constructions.c3ce55048: nine files, +690/-44; 366 added lines are tests/fixtures. Review this commit for the consumer itself. The merge parent isd0fe052be21985cf89c87173f616f2c0ce31eedf.The selector chain inherits #524/#526's separate cached-priority ordering prerequisite #538. Merge that queue fix before using the chain.
Validation on Zulu JDK 11.0.32.1, Node 22.23.1 and npm 10.9.8:
TsAnalysisSessionTesttests passed on the integrated core, covering retained initialization/queries, cumulative limits, lifecycle ownership and phase snapshots.ignoreFailures=falseand no findings. All seven new session tests passed again after the formatting-only lint corrections.git diff --checkpassed.Current-head GitHub CI starts when this PR is opened and is separate from the local validation above. Benchmark campaigns remain paused.
Refs #481.