Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/design/code-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ screenshots (R1–R4). The work is tracked in [#319](https://github.com/TypeSafe
This page is CR-1's contract ([#320](https://github.com/TypeSafeAI/modex/issues/320)). Every later
slice works against it.

**Where it stands (2026-11-01).** The core CR-1 through CR-7 slices have landed on `main`, and Code Review is present but hidden in the v0.4 releases, whose built apps require the local switch `modex.codeReview` to be `on`. From v0.4.2 a setting in Settings → General replaces that switch, off by default; Val chose on 2026-11-03 to keep Code Review hidden until its gates pass. Built apps required the switch because Gate A (#319) is not accepted ([v0.4.0 review](../reviews/2026-10-24-v0.4.0-release-review.md)). The candidate also carries the CR-7 sign-out/draft regression and CR-4 through CR-7 accessibility coverage (C76). Remaining engineering work is composer-clearance verification. C58 attachments and C59 effort remain omitted without an approved deviation, alongside the unresolved composer decisions below. Original-reference comparison, human keyboard/VoiceOver, the live CR-6 smoke and the CR-7 canary retain their separate acceptance gates. Each issue's ticked boxes and next action are in [status.md](../status.md#open-issue-checklists).
**Where it stands (2026-11-13).** The core CR-1 through CR-7 slices are on `main`; built apps keep Code Review hidden by default, with Settings → General available from v0.4.2. Val chose on 2026-11-03 to retain that default until the gates pass. The November 4 [decision record](#open-decisions) approves logins only, the built revision-bound local Viewed toggle, removal of C07, no access-mode indicator, and omission of C58 attachments/C59 effort while retaining model selection. Composer-clearance and CR-4 through CR-7 accessibility have fixture coverage; human keyboard/VoiceOver remains open. Val retired the original-image comparison in favour of a real-PR benchmark. A [new ten-PR comparison and live read-only controls check](../reviews/2026-11-13-cr-real-pr-benchmark.md) now covers the fixed build delivered by #520 as `967b703`; it preserves remaining thread/navigation limitations and does not tick issue boxes whose literal text still requires the original comparison. The real CR-6 provider smoke, Val-named disposable-repository CR-7 canary, human acceptance and default activation remain separate gates. Each issue’s ticked boxes and next action are in [status.md](../status.md#open-issue-checklists).

CR-1 itself added a pure read contract, synthetic fixtures and this page, with no IPC channel, UI or
GitHub request. Gate A then followed in order:
Expand Down
6 changes: 4 additions & 2 deletions docs/reviews/2026-11-01-cr8-acceptance-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Columns as in the baseline: **Fixture** (Node tests, or real Electron with synth
**Authenticated** (read-only through a real `gh` login), **Live provider / write** (an authorized native-CLI turn,
#325; an authorized write on a disposable target, #326), **Human** (a person, keyboard/VoiceOver or references).

**Dated follow-up, 2026-11-13.** The [real-PR benchmark](2026-11-13-cr-real-pr-benchmark.md) now records ten public PR comparisons on source `f9bef70`, whose complete tree matches protected main `967b703` delivered through #520. Real instructions/Escape focus restoration, pointer/keyboard resizing and nine narrow-window controls also passed. The [protected delivery receipt](2026-11-13-cr-inline-integration.md#actual-protected-delivery) keeps full source and merge-group counts separate. The dated baseline rows below retain their original evidence; this follow-up neither replaces historical failures nor accepts human, real-provider/write, original-reference wording or default activation gates.

## Environments added since the baseline

| ID | What ran | SHA | Result |
Expand Down Expand Up @@ -45,7 +47,7 @@ Status values: *built*, *unavailable*, *deviation Dn*, *needs decision N*, *unch
inventory left a control out. "unverified" in a Fixture cell means the control is in the code but no spec was
found that asserts it; it is not a pass. Since 2026-11-04 no status is *needs decision N*. A Human cell that
reads "open: reference comparison" names a comparison Val retired on 2026-11-04; it stays open until the
benchmark on real pull requests is recorded and the issue text that names the comparison is met or changed.
benchmark on real pull requests is recorded and the issue text that names the comparison is met or changed. The [2026-11-13 benchmark](2026-11-13-cr-real-pr-benchmark.md) supplies new authenticated evidence; literal issue-text reconciliation remains open.

| ID | Control | Owner | Status | Fixture | Authenticated | Live provider / write | Human |
| --- | --- | --- | --- | --- | --- | --- | --- |
Expand Down Expand Up @@ -184,7 +186,7 @@ and C07 is removed.

| AC | Where it stands on `0a8c513` |
| --- | --- |
| AC1 R1–R4 in real Electron | All four reached through real controls over production reads with synthetic `gh` (`F-1101` journey). The original references are gone. On 2026-11-04 Val retired the comparison in favour of a benchmark on real pull requests against GitHub's pages; that benchmark has not run, and this does not tick a box whose text still requires the comparison. |
| AC1 R1–R4 in real Electron | All four reached through real controls over production reads with synthetic `gh` (`F-1101` journey). The original references are gone. On 2026-11-04 Val retired the comparison in favour of a benchmark on real pull requests against GitHub's pages; the [new ten-PR benchmark](2026-11-13-cr-real-pr-benchmark.md) and real instructions/narrow controls are now recorded on the tree delivered as `967b703`. This does not tick a box whose literal text still requires the original comparison. |
| AC2 every visible control has behaviour or an explicit unavailable state | Partial: C07 is removed and C65 is built (decisions 6 and 5). C58 attachment and C59 reasoning effort are approved omissions (Val, 2026-11-04). The other controls are mapped above; seven built controls also lack an asserting spec (follow-ups below). |
| AC3 isolation, injection, incomplete data, at-most-once | Met at fixture: read regressions, native denial on 2.1.316 (`N`), agent stop/unknown/restart, write at-most-once and reconciliation (`F-1101`). **Open:** the live smoke (#325) and live canary (#326). |
| AC4 local Changes, navigation, conversation and approvals intact | `S-1101`: unit green; the local E2E had one non-Code-Review failure that passed alone, so it is not counted as green. The hosted required check passed on `c1f74c7`. |
Expand Down
16 changes: 16 additions & 0 deletions docs/reviews/2026-11-13-cr-inline-integration.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Code Review line-comment integration

**Delivery follow-up:** #520 is on protected main as signed squash `967b703768d040d64456c7d118548b97a3bae35b`; see [actual protected delivery](#actual-protected-delivery). Pending sentences in the dated source-development record below describe their original checkpoints.

This owned integration starts from protected main `927b443414befe5f4300bb3f3d39af4666032609` and merges ready PR #513 source `c599dd7a9fbaeb4d6946666d8859e892e6847aca`, preserving its history and authors. The original owner branch and worktree are unchanged. Git independently reports only a `docs/status.md` conflict; this branch retains the full current-main file and applies narrow, evidence-backed status additions instead of reviving closed #378 or discarding delivered LM/CF/browser facts.

The feature reads the first 100 REST diff-line comments into Activity, preserves line/file target provenance, labels file/line/replies and unavailable current-line positions, and reports partial, malformed or capped reads. Comment text remains untrusted Markdown. Resolved-thread state, placement beside changed lines and later comment pages are not implemented by this slice and remain part of their accepted parent requirements. No default activation or new live-write authority is implied.
Expand Down Expand Up @@ -43,3 +45,17 @@ Frozen signed runtime/test source `57d2773e755259a2e618e40f62e179bd8f5d6d8c`, tr
The seventeen desktop skips are four live-provider cases, four local-model native cases, three Open Knowledge cases and six installed-CLI Code Review cases. They are not acceptance passes. The six Code Review cases were then separately qualified on the same unchanged inputs: four ordinary passes and two intentional expected-failure controls in 22.1 seconds, using installed Claude Code 2.1.323, Electron 44.4.5, Chromium 152.0.7977.130 and embedded Node 24.21.0 on macOS 27.2.1 arm64. The actual CLI consumed hostile PR content, allowed selected evidence and refused outside-secret/symlink reads, shell, write, fetch, MCP and the placeholder; forbidden effect markers remained absent. Three native starts were recorded; root independently observed their three PIDs absent and their three provider ports refusing connections. Fifty native output files and all three owned fixture trees were independently byte-compared. Incoming GH_TOKEN was already absent, so this is not a supplied-token native scrub challenge. The provider and GitHub payloads were scripted, with no paid inference or live product write; cleanup observations cover sampled recorded children, not every possible descendant.

One fresh whole-branch review and every ruling are retained, with no Critical/Important finding and no deferred Minor. The first coalesced review correction and the subsequent public-schema correction remain separately identified above. No second feature review was requested; the later CI-only correction received its own scoped review. The complete signed recovery restores into an empty bare repository, passes full fsck and reproduces all thirteen authored files byte-for-byte; original #513 source history and authorship remain ancestors. The final qualification-record commit changes documentation only; every runtime/test/dependency input stays byte-exact to the qualified source. Source-hosted CI, actual protected delivery and merged-tree equivalence remain pending. This is a reviewable implementation candidate, not whole-parent, human/live-provider/live-write, release or default-activation acceptance.

## Actual protected delivery

#520 merged on 2026-11-13 at 05:53:08 UTC as signed squash `967b703768d040d64456c7d118548b97a3bae35b`, parent `927b443414befe5f4300bb3f3d39af4666032609`, tree `6a241c26d089ac4d7daf3e4b30b23a28257010c5`. GitHub signature verification passed. The complete tree equals final qualified source `f9bef700390eb300d40424699193b2731d00e36c`; original #513 source remains in the integration/recovery history, while main records the squash. #513 was closed as superseded with [its reconciliation receipt](https://github.com/TypeSafeAI/modex/pull/513#issuecomment-6845436906), preserving its owner’s local branch and checkout.

[Actual protected run 43370489247](https://github.com/TypeSafeAI/modex/actions/runs/43370489247/job/131704833478) checked out that exact squash and passed 2,587 units with 36 skips, 533 desktop cases with fourteen opt-in skips in 32.4 minutes, eight site cases in 23.0 seconds and four web cases in 4.2 seconds. No unit failure/cancellation or retry annotation was recorded. The 4,826-byte memory artifact has SHA-256 `ad0aa17380fe8db1c39c76fabba97c5cc7f6256e8b36de1f460023d0fad5a931`; the 9,133,856-byte E2E artifact has SHA-256 `946a9f46aedbb2079a74337262f109829667c337b9656ae4619fc6cbb819e234`. Both match API digests and pass ZIP integrity. Merge-group iPhone and coverage-upload jobs skipped as configured; separately triggered post-merge checks are not this protected run.

Corrected source [run 43366524777](https://github.com/TypeSafeAI/modex/actions/runs/43366524777) passed all twelve checks. Its actual preview `8aaa11eb9468a2b23ff3529e86eb61382fb4d561`, parents `927b443` and `f9bef70`, has the same independently reproduced tree. Source macOS qualification passed 2,587 units with 36 skips, 533 desktop cases with fourteen opt-in skips in 25.5 minutes, eight site cases and four web cases. The complete iPhone results contain 65 native-unit passes, 43 ordinary UI passes and one intentional expected-failure control, with zero unexpected failures/skips. All four source artifacts passed API-digest and ZIP checks, including the 87,207,851-byte iPhone artifact with SHA-256 `6fcbf42641cace781e11a3f52aa8141ded3feb11e06a9ac84f7a62a2acadc544`.

The first iPhone job in run `43360620861` hit its confirmed 30-minute whole-job maximum after 65 native-unit passes and 39 UI-case pass lines including one intentional expected failure; another case was running and its paired result bundle was incomplete. The separately reviewed correction raised only the whole iPhone job limit to 45 minutes. Individual waits, assertions, cases and retries stayed unchanged. Two workflow regression tests passed; the CI-only review found no severity findings. The later successful job used a different hosted runner, so the budget change alone is not proved to have caused the pass. The first cancellation and its artifact remain retained in the [published first-failure receipt](https://github.com/TypeSafeAI/modex/pull/520#issuecomment-6843893746).

The [new real-PR benchmark](2026-11-13-cr-real-pr-benchmark.md) adds authenticated rendered evidence on the source-identical tree; it does not turn scripted-provider, simulator, sampled cleanup or automated keyboard results into real-provider/write, physical-device or human acceptance. No parent issue or default activation is accepted by this slice.

The session-owned checkout was released and removed only through the guarded helper. Its new recovery bundle has SHA-256 `457c2fc561ce3588579bea811ae1cd693cd3945ca3fccb1d8bfa2d99d67000ad`; an independent empty-bare restore passed full fsck, verified all six own SSH signatures and reproduced all fourteen authored files byte-for-byte. All 38 owned probe files retain their original tree outside the removed checkout and independent byte-verified copies. Other owners’ worktrees and branches remain preserved.
Loading
Loading