Skip to content

docs: reconcile Code Review delivery and real-PR benchmark - #521

Merged
BunsDev merged 1 commit into
mainfrom
cr-benchmark-record
Nov 13, 2026
Merged

BunsDev merged 1 commit into
mainfrom
cr-benchmark-record

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Code Review documentation still described #520 as awaiting delivery, the real-PR benchmark as unrun, and several November 4 decisions as unresolved. This update reconciles the design, status and acceptance matrix with protected main 967b703768d040d64456c7d118548b97a3bae35b and adds the new ten-PR benchmark record.

The records preserve actual source/protected/iPhone provenance, the first job cancellation and both diagnosed benchmark-probe failures. They document real comment/reply/unavailable-line rendering, instructions/focus, resizing and narrow controls, plus remaining thread coverage and usability friction. Original-reference issue wording, human accessibility, real-provider review, live-write/device acceptance and default activation retain their separate gates.

  • pnpm build passed; pnpm test passed 2,587 cases with 36 skips, zero failures/cancellations, on the frozen five-file documentation candidate.
  • One scoped independent review found zero Critical, Important or Minor findings. All eleven declined behaviors have explicit root rulings retaining their requirements; no second review loop was requested.
  • All 16 new relative links resolve. The exact new receipt renders through GitHub GFM and a private browser preview with 13 paragraphs, no forced breaks and no horizontal overflow. All 852 runtime/test/dependency inputs remain byte-identical to the qualified implementation, so existing UI/native evidence retains its original scope and revisions.

Signed source is 1ad5dc958abd2e6ad012263dd2a75392a9458af9. The private recovery bundle restores into an empty bare repository, passes full fsck and reproduces all five reviewed documents. Source CI run 43377821836 passed all ten applicable checks on preview 0c6fae32793eea7dc932c0f426ff818cb6c20466, tree 7c4a96f32c41ffb03279b7ea5762b2d7f934df8e, independently reproduced from main 967b703 and signed source 1ad5dc9. It passed 2,587 units with 36 skips, 533 desktop cases with 14 opt-in skips in 44.1 minutes, eight site cases and four web cases, with no retry annotations. Both complete iPhone bundles passed: 65 native units, 43 ordinary UI cases and one intentional expected-failure control, zero unexpected failures/skips. All four artifacts match API digests and pass ZIP integrity. These are hosted fixture/simulator results. Protected queue run 43384781362 also passed on the actual merged commit 63a64edf2ccbb2a512ee0cc5e7a1c7aeaa1f3638, merged at 2026-11-13 08:06:22 UTC. Its signed single-parent commit has the exact qualified source tree 7c4a96f32c41ffb03279b7ea5762b2d7f934df8e. The actual protected checkout passed 2,587 units with 36 skips, 533 desktop cases with 14 opt-in skips in 38.4 minutes, eight site cases and four web cases, zero retry annotations; both protected artifacts match API digests and pass ZIP checks. The protected iPhone job was skipped; the separate complete source iPhone evidence above remains simulator evidence. No release or human/live-provider/write/device acceptance is inferred. Related: #319, #327.

Record the protected inline-comment delivery, current accepted decisions and new authenticated benchmark while retaining the literal issue, human, provider and activation gates.
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 13, 2026 6:18am UTC
modex-app Building Building Preview Nov 13, 2026 6:18am UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 967b703 cr-benchmark-record 1ad5dc9 +/-
65% 65% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 63a64ed Nov 13, 2026
11 checks passed
@BunsDev
BunsDev deleted the cr-benchmark-record branch November 13, 2026 08:06

This branch was successfully deployed

1 active deployment
Preview – modex — 1ad5dc95 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant