Repository navigation
docs: reconcile Code Review delivery and real-PR benchmark - #521
Merged
Merged
Conversation
Record the protected inline-comment delivery, current accepted decisions and new authenticated benchmark while retaining the literal issue, human, provider and activation gates.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review documentation still described #520 as awaiting delivery, the real-PR benchmark as unrun, and several November 4 decisions as unresolved. This update reconciles the design, status and acceptance matrix with protected main
967b703768d040d64456c7d118548b97a3bae35band adds the new ten-PR benchmark record.The records preserve actual source/protected/iPhone provenance, the first job cancellation and both diagnosed benchmark-probe failures. They document real comment/reply/unavailable-line rendering, instructions/focus, resizing and narrow controls, plus remaining thread coverage and usability friction. Original-reference issue wording, human accessibility, real-provider review, live-write/device acceptance and default activation retain their separate gates.
pnpm buildpassed;pnpm testpassed 2,587 cases with 36 skips, zero failures/cancellations, on the frozen five-file documentation candidate.Signed source is
1ad5dc958abd2e6ad012263dd2a75392a9458af9. The private recovery bundle restores into an empty bare repository, passes full fsck and reproduces all five reviewed documents. Source CI run43377821836passed all ten applicable checks on preview0c6fae32793eea7dc932c0f426ff818cb6c20466, tree7c4a96f32c41ffb03279b7ea5762b2d7f934df8e, independently reproduced from main967b703and signed source1ad5dc9. It passed 2,587 units with 36 skips, 533 desktop cases with 14 opt-in skips in 44.1 minutes, eight site cases and four web cases, with no retry annotations. Both complete iPhone bundles passed: 65 native units, 43 ordinary UI cases and one intentional expected-failure control, zero unexpected failures/skips. All four artifacts match API digests and pass ZIP integrity. These are hosted fixture/simulator results. Protected queue run 43384781362 also passed on the actual merged commit63a64edf2ccbb2a512ee0cc5e7a1c7aeaa1f3638, merged at 2026-11-13 08:06:22 UTC. Its signed single-parent commit has the exact qualified source tree7c4a96f32c41ffb03279b7ea5762b2d7f934df8e. The actual protected checkout passed 2,587 units with 36 skips, 533 desktop cases with 14 opt-in skips in 38.4 minutes, eight site cases and four web cases, zero retry annotations; both protected artifacts match API digests and pass ZIP checks. The protected iPhone job was skipped; the separate complete source iPhone evidence above remains simulator evidence. No release or human/live-provider/write/device acceptance is inferred. Related: #319, #327.