Skip to content

Confirm companion private IPv4 policy and acceptance evidence (#109) - #509

Merged
BunsDev merged 3 commits into
mainfrom
companion109-final
Nov 12, 2026
Merged

BunsDev merged 3 commits into
mainfrom
companion109-final

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Confirms Val’s 2026-11-12 decision for #109: keep the current private-IPv4 behavior, including VPN tunnels and virtual bridges. Public, CGNAT, link-local, internal and IPv6 addresses remain excluded. The existing policy test now accurately describes address eligibility; its assertions and companion production behavior are unchanged.

Updates the current docs and historical evidence map to recognize that PR #421 merged and that the VPN policy is settled. Val cannot run the physical two-LAN phone procedure now, so its rows remain unrun and #109 stays open. The receipt distinguishes mocked selection, real-socket races, UI checks, hosted checks and physical acceptance.

Integrates current main and retains its 70-minute macOS CI budget from PR #512 byte-for-byte. No CI workflow change remains in this PR’s net diff. Earlier timed-out attempts, the unproven keyboard Copy failure, and superseded green runs are retained as historical receipts; they do not substitute for final integrated qualification.

Integrated local build and typechecks pass, and both pairing UI cases pass. The complete integrated unit suite passes 2,534 cases with 36 explicit skips, zero failures and zero cancellations. Earlier focused companion checks passed all 30 cases with no LAN skips. See docs/reviews/2026-11-12-companion-network-policy.md for exact qualification identities and the remaining physical gate.

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 12, 2026 4:01pm UTC
modex-app Error Error Nov 12, 2026 4:01pm UTC

Request Review

@github-code-quality

github-code-quality Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 5a580d4 companion109-final 03fb58b +/-
66% 66% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 12, 2026 16:57 UTC

@BunsDev
BunsDev added this pull request to the merge queue Nov 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 12, 2026
@BunsDev
BunsDev added this pull request to the merge queue Nov 12, 2026
@BunsDev BunsDev closed this Nov 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a manual request Nov 12, 2026
@BunsDev BunsDev changed the title Confirm companion VPN and bridge policy for #109 Confirm companion network policy and allow complete CI qualification (#109) Nov 12, 2026
@BunsDev BunsDev reopened this Nov 12, 2026
@BunsDev
BunsDev added this pull request to the merge queue Nov 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 12, 2026
@BunsDev BunsDev changed the title Confirm companion network policy and allow complete CI qualification (#109) Confirm companion private IPv4 policy and acceptance evidence (#109) Nov 12, 2026
@BunsDev
BunsDev added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 6de7096 Nov 12, 2026
15 of 16 checks passed
@BunsDev
BunsDev deleted the companion109-final branch November 12, 2026 19:33

This branch was successfully deployed

1 active deployment
Preview – modex — 03fb58be Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant