Repository navigation
Confirm companion private IPv4 policy and acceptance evidence (#109) - #509
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a manual request
Nov 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirms Val’s 2026-11-12 decision for #109: keep the current private-IPv4 behavior, including VPN tunnels and virtual bridges. Public, CGNAT, link-local, internal and IPv6 addresses remain excluded. The existing policy test now accurately describes address eligibility; its assertions and companion production behavior are unchanged.
Updates the current docs and historical evidence map to recognize that PR #421 merged and that the VPN policy is settled. Val cannot run the physical two-LAN phone procedure now, so its rows remain unrun and #109 stays open. The receipt distinguishes mocked selection, real-socket races, UI checks, hosted checks and physical acceptance.
Integrates current main and retains its 70-minute macOS CI budget from PR #512 byte-for-byte. No CI workflow change remains in this PR’s net diff. Earlier timed-out attempts, the unproven keyboard Copy failure, and superseded green runs are retained as historical receipts; they do not substitute for final integrated qualification.
Integrated local build and typechecks pass, and both pairing UI cases pass. The complete integrated unit suite passes 2,534 cases with 36 explicit skips, zero failures and zero cancellations. Earlier focused companion checks passed all 30 cases with no LAN skips. See docs/reviews/2026-11-12-companion-network-policy.md for exact qualification identities and the remaining physical gate.