Refactor constants to UPPER_SNAKE_CASE and misc cleanup#192
Merged
Conversation
- Apply camelCase convention to all shared constants files (Constants, DriveConstants, FeederConstants, LauncherConstants, IntakeConstants) - Apply UPPER_SNAKE_CASE to private static final fields in IO implementation classes - Move sim-only DCMotor/gain constants out of shared constants into their respective sim IO classes (TurretIOSimSpark, FlywheelIOSimWPI, KickerIOSimSpark, SpindexerIOSimSpark, RollerIOSimSpark/TalonFX) - Merge TurretIOSpark and TurretIOSimSpark gains into common kP/kD fields in TurretConstants Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All public/private static final fields in Constants, DriveConstants, LauncherConstants, FeederConstants, IntakeConstants, and VisionConstants now use UPPER_SNAKE_CASE per Java convention. k-prefix gain constants (kP, kD, kAllowableError, etc.) are left unchanged per FRC convention. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add .gitattributes enforcing eol=lf for all text files, and convert all existing tracked files from CRLF to LF. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The blanket .vscode/ rule at the bottom conflicted with the selective allowlist above it (.vscode/settings.json, launch.json, etc.). Removing it so the allowlist takes effect and tracked .vscode files remain tracked. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ntralize roller gains Extends the naming convention refactor to VisionConstants, DriveConstants, FeederConstants, LauncherConstants, LEDConstants, and general Constants; centralizes shared roller PID/torque gains into IntakeConstants.RollerConstants so real and sim IO classes share a single source of truth. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces the separate CAMERA_*_NAME and ROBOT_TO_*_CAMERA constants with a CameraConfig record, and updates VisionIOPhotonVision and VisionIOPhotonVisionSim to accept a CameraConfig directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Completes UPPER_SNAKE_CASE constant renaming across drive, feeder, intake, and launcher subsystems. Also removes unused FREE_SPEED constants from motor classes and adjusts default current limits to safer values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds *.glb binary to .gitattributes so line-ending normalization never touches GLB files. Restores model.glb to its pre-normalization state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public static finalconstants across shared constants files (Constants,DriveConstants,FeederConstants,IntakeConstants,LauncherConstants,VisionConstants,LEDConstants) toUPPER_SNAKE_CASEper Java convention;k-prefix gain fields left unchanged per FRC conventionCameraConfigpairs up a camera name with its associated robot-to-camera transformRollerConfigwas simplified from a class to a RecordFREE_SPEEDconstants from motor constant classes.gitattributesTest plan
./gradlew build)CameraConfigrecordsgit diff --check)🤖 Generated with Claude Code