Skip to content

fix(edge): ACP MCP 未接线时发可见降级事件 #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeliciousBuding merged 1 commit into from
Aug 17, 2026
+14 −1
Merged

fix(edge): ACP MCP 未接线时发可见降级事件 #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion edge-server/internal/adapters/acp_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,20 @@ func runACPSession(ctx context.Context, stdout io.Reader, stdin io.Writer, emitt
initResp.ProtocolVersion, acp.ProtocolVersionNumber))
}

// 2. session/new.
// 2. session/new. MCP server config from the run profile is not yet wired
// into the ACP session (frame design deferred, #1404). When a profile
// declares MCP servers, surface the gap as a visible status-change event
// + warning log so the user sees *why* MCP tools are unavailable instead
// of a silent absence.
if rc.MCPConfig != "" {
slog.Warn("acp: MCP config present but not wired into ACP session; MCP tools will be unavailable",
"run_id", run.ID, "reason", "acp_mcp_not_wired")
emitter.Emit(BusEventStatusChange, acpRunScope(run), map[string]any{
"status": "degraded",
"reason": "acp_mcp_not_wired",
"message": "MCP servers configured in this profile are not available in the ACP execution path",
})
}
sessResp, err := conn.NewSession(ctx, acp.NewSessionRequest{
Cwd: rc.WorkDir,
McpServers: []acp.McpServer{}, // TODO(#1404): wire RunProcessContext.MCPConfig
Expand Down
Loading