fix(edge): ACP MCP 未接线时发可见降级事件 - #1740
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
runACPSession 在 rc.MCPConfig 非空时发 BusEventStatusChange(status=degraded, reason=acp_mcp_not_wired)+ slog.Warn,把静默的 MCP 工具不可用变成可见失败。full wiring 留给 #1404。 Co-authored-by: Cursor <cursor@vectorcontrol.tech>
4f0c420 to
a1ed78c
Compare
背景
ACP 是默认执行路径(claude-acp/codex-acp/opencode-acp),但
runACPSession硬编码空McpServers,完全不读rc.MCPConfig。用户在 profile 配了 MCP server 跑 ACP adapter 时 MCP 工具静默不可用,没有任何 event/log 提示原因。违反 AGENTS.md §10 演示诚实——能力被 advertised 但不工作。变更
edge-server/internal/adapters/acp_client.go:runACPSession在rc.MCPConfig != ""时发BusEventStatusChange(status=degraded, reason=acp_mcp_not_wired)+slog.Warn,把静默 gap 变成可见失败。full wiring(解析 MCPConfig JSON →[]acp.McpServer)留给 edge: ACP 协议增量采纳 — spike 验证(管理员已批:增量路线,三家现有 adapter 不动) #1404 frame design。证据
real_tested=false:单元测试编译通过;未跑真实 ACP adapter + MCP server。go build ./...+go test ./internal/adapters/... -short -count=1(全绿)+go vet+gofmt -l(干净)全绿。关联
审计 P1-4:ACP 默认执行路径静默丢弃 MCP 配置。