Skip to content

fix(edge): ACP MCP 未接线时发可见降级事件 - #1740

Merged
DeliciousBuding merged 1 commit into
masterfrom
fix/edge-acp-mcp-visible
Aug 17, 2026
Merged

fix(edge): ACP MCP 未接线时发可见降级事件#1740
DeliciousBuding merged 1 commit into
masterfrom
fix/edge-acp-mcp-visible

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

背景

ACP 是默认执行路径(claude-acp/codex-acp/opencode-acp),但 runACPSession 硬编码空 McpServers,完全不读 rc.MCPConfig。用户在 profile 配了 MCP server 跑 ACP adapter 时 MCP 工具静默不可用,没有任何 event/log 提示原因。违反 AGENTS.md §10 演示诚实——能力被 advertised 但不工作。

变更

证据

  • real_tested=false:单元测试编译通过;未跑真实 ACP adapter + MCP server。
  • 本地门禁:go build ./... + go test ./internal/adapters/... -short -count=1(全绿)+ go vet + gofmt -l(干净)全绿。

关联

审计 P1-4:ACP 默认执行路径静默丢弃 MCP 配置。

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DeliciousBuding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e4ba2e4f-04be-4642-8a3f-dd8623c5fd29

📥 Commits

Reviewing files that changed from the base of the PR and between 414ff55 and a1ed78c.

📒 Files selected for processing (1)
  • edge-server/internal/adapters/acp_client.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

runACPSession 在 rc.MCPConfig 非空时发 BusEventStatusChange(status=degraded, reason=acp_mcp_not_wired)+ slog.Warn,把静默的 MCP 工具不可用变成可见失败。full wiring 留给 #1404。

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
@DeliciousBuding
DeliciousBuding force-pushed the fix/edge-acp-mcp-visible branch from 4f0c420 to a1ed78c Compare August 17, 2026 10:52
@DeliciousBuding
DeliciousBuding merged commit ff81a68 into master Aug 17, 2026
33 checks passed
@DeliciousBuding
DeliciousBuding deleted the fix/edge-acp-mcp-visible branch August 17, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant