setup.sh: make submodule checks independent of working directory - #4488
Open
GITTYCAT12 wants to merge 2 commits into
Open
setup.sh: make submodule checks independent of working directory#4488GITTYCAT12 wants to merge 2 commits into
GITTYCAT12 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates setup.sh to run git submodule commands within the directory specified by
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
setup.shsays it can be invoked from any working directory, but the initialgit submodule statusandgit submodule updatecommands run against the caller's current directory rather than the ORFS checkout.This can make setup fail when the script is launched from outside the repository.
This PR uses the already-resolved
DIRpath withgit -Cfor both submodule operations, keeping the setup behavior independent of the caller's working directory.Validation
The change is intentionally limited to the submodule commands. I would appreciate CI/maintainer validation on the supported Linux and macOS setup paths, particularly when invoking
setup.shfrom a directory outside the ORFS checkout.Related behavior
The script already resolves its own location into
DIRand uses that path for the dependency installer, so this keeps the submodule handling consistent with the rest of the script.