Skip to content

Tightened up hercules_is_int/hercules_idecode core area #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openroad-ci wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tightened up hercules_is_int/hercules_idecode core area #4161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flow/designs/rapidus2hp/hercules_idecode/config.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ export CORE_UTILIZATION = $(strip \
45 \
), \
$(if $(filter slang,$(SYNTH_HDL_FRONTEND)), \
58, \
54 \
59, \
58 \
) \
), \
$(if $(and $(filter t0.5,$(RAPIDUS_PDK_VERSION)),$(filter SC5T,$(PLACE_SITE))), \
Expand Down
34 changes: 27 additions & 7 deletions flow/designs/rapidus2hp/hercules_idecode/rules-base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,31 @@
"compare": "=="
},
"placeopt__design__instance__area": {
"value": 9732,
"value": 9648,
"compare": "<="
},
"placeopt__design__instance__count__stdcell": {
"value": 214023,
"value": 212534,
"compare": "<="
},
"detailedplace__design__violations": {
"value": 0,
"compare": "=="
},
"cts__design__instance__count__setup_buffer": {
"value": 18611,
"value": 18481,
"compare": "<="
},
"cts__design__instance__count__hold_buffer": {
"value": 18611,
"value": 18481,
"compare": "<="
},
"cts__timing__setup__ws": {
"value": -0.0772,
"value": -0.0586,
"compare": ">="
},
"cts__timing__setup__tns": {
"value": -0.381,
"value": -0.315,
"compare": ">="
},
"cts__timing__hold__ws": {
Expand All @@ -52,7 +52,7 @@
"compare": ">="
},
"globalroute__timing__setup__tns": {
"value": -97.2,
"value": -6.06,
"compare": ">="
},
"globalroute__timing__hold__ws": {
Expand All @@ -62,5 +62,25 @@
"globalroute__timing__hold__tns": {
"value": -0.05,
"compare": ">="
},
"finish__timing__setup__ws": {
"value": -0.101,
"compare": ">="
},
"finish__timing__setup__tns": {
"value": -6.06,
"compare": ">="
},
"finish__timing__hold__ws": {
"value": -0.0185,
"compare": ">="
},
"finish__timing__hold__tns": {
"value": -0.074,
"compare": ">="
},
"finish__design__instance__area": {
"value": 9917,
"compare": "<="
}
}
38 changes: 29 additions & 9 deletions flow/designs/rapidus2hp/hercules_idecode/rules-verific.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,31 @@
"compare": "=="
},
"placeopt__design__instance__area": {
"value": 9790,
"value": 9688,
"compare": "<="
},
"placeopt__design__instance__count__stdcell": {
"value": 214546,
"value": 212745,
"compare": "<="
},
"detailedplace__design__violations": {
"value": 0,
"compare": "=="
},
"cts__design__instance__count__setup_buffer": {
"value": 18656,
"value": 18500,
"compare": "<="
},
"cts__design__instance__count__hold_buffer": {
"value": 18656,
"value": 18500,
"compare": "<="
},
"cts__timing__setup__ws": {
"value": -0.0782,
"value": -0.0754,
"compare": ">="
},
"cts__timing__setup__tns": {
"value": -0.392,
"value": -0.333,
"compare": ">="
},
"cts__timing__hold__ws": {
Expand All @@ -44,15 +44,15 @@
"compare": ">="
},
"globalroute__antenna_diodes_count": {
"value": 186,
"value": 184,
"compare": "<="
},
"globalroute__timing__setup__ws": {
"value": -0.0894,
"value": -0.0849,
"compare": ">="
},
"globalroute__timing__setup__tns": {
"value": -224.0,
"value": -48.2,
"compare": ">="
},
"globalroute__timing__hold__ws": {
Expand All @@ -62,5 +62,25 @@
"globalroute__timing__hold__tns": {
"value": -0.05,
"compare": ">="
},
"finish__timing__setup__ws": {
"value": -0.0849,
"compare": ">="
},
"finish__timing__setup__tns": {
"value": -48.3,
"compare": ">="
},
"finish__timing__hold__ws": {
"value": -0.0185,
"compare": ">="
},
"finish__timing__hold__tns": {
"value": -0.074,
"compare": ">="
},
"finish__design__instance__area": {
"value": 9964,
"compare": "<="
}
}
4 changes: 2 additions & 2 deletions flow/designs/rapidus2hp/hercules_idecode/test/test_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ def get_exp_util(self, place_site, pdk_version, front_end):
return 45
return 45
if front_end in ["", "slang"]:
return 58
return 54
return 59
return 58
if pdk_version == "t0.5" and place_site == "SC5T":
if front_end in ["", "slang"]:
return 48
Expand Down
7 changes: 2 additions & 5 deletions flow/designs/rapidus2hp/hercules_is_int/config.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,8 @@ export CORE_UTILIZATION = $(strip \
), \
$(if $(filter 0.3,$(RAPIDUS_PDK_VERSION)), \
$(if $(filter ra02h138_DST_45CPP SC6T,$(PLACE_SITE)), \
52, \
$(if $(filter slang,$(SYNTH_HDL_FRONTEND)), \
60, \
61 \
) \
55, \
57 \
), \
$(if $(and $(filter t0.5,$(RAPIDUS_PDK_VERSION)),$(filter SC5T,$(PLACE_SITE))), \
45, \
Expand Down
32 changes: 26 additions & 6 deletions flow/designs/rapidus2hp/hercules_is_int/rules-base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
"compare": "<="
},
"cts__timing__setup__ws": {
"value": -0.177,
"value": -0.176,
"compare": ">="
},
"cts__timing__setup__tns": {
"value": -368.0,
"value": -448.0,
"compare": ">="
},
"cts__timing__hold__ws": {
Expand All @@ -44,23 +44,43 @@
"compare": ">="
},
"globalroute__antenna_diodes_count": {
"value": 479,
"value": 477,
"compare": "<="
},
"globalroute__timing__setup__ws": {
"value": -0.263,
"value": -0.258,
"compare": ">="
},
"globalroute__timing__setup__tns": {
"value": -1050.0,
"value": -1280.0,
"compare": ">="
},
"globalroute__timing__hold__ws": {
"value": -0.0343,
"compare": ">="
},
"globalroute__timing__hold__tns": {
"value": -0.703,
"value": -1.7,
"compare": ">="
},
"finish__timing__setup__ws": {
"value": -0.258,
"compare": ">="
},
"finish__timing__setup__tns": {
"value": -1060.0,
"compare": ">="
},
"finish__timing__hold__ws": {
"value": -0.0472,
"compare": ">="
},
"finish__timing__hold__tns": {
"value": -1.7,
"compare": ">="
},
"finish__design__instance__area": {
"value": 30174,
"compare": "<="
}
}
32 changes: 26 additions & 6 deletions flow/designs/rapidus2hp/hercules_is_int/rules-verific.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
"compare": "<="
},
"cts__timing__setup__ws": {
"value": -0.164,
"value": -0.193,
"compare": ">="
},
"cts__timing__setup__tns": {
"value": -332.0,
"value": -448.0,
"compare": ">="
},
"cts__timing__hold__ws": {
Expand All @@ -48,19 +48,39 @@
"compare": "<="
},
"globalroute__timing__setup__ws": {
"value": -0.212,
"value": -0.239,
"compare": ">="
},
"globalroute__timing__setup__tns": {
"value": -983.0,
"value": -1190.0,
"compare": ">="
},
"globalroute__timing__hold__ws": {
"value": -0.0125,
"value": -0.0394,
"compare": ">="
},
"globalroute__timing__hold__tns": {
"value": -0.581,
"value": -1.37,
"compare": ">="
},
"finish__timing__setup__ws": {
"value": -0.239,
"compare": ">="
},
"finish__timing__setup__tns": {
"value": -1190.0,
"compare": ">="
},
"finish__timing__hold__ws": {
"value": -0.0394,
"compare": ">="
},
"finish__timing__hold__tns": {
"value": -1.37,
"compare": ">="
},
"finish__design__instance__area": {
"value": 30446,
"compare": "<="
}
}
6 changes: 2 additions & 4 deletions flow/designs/rapidus2hp/hercules_is_int/test/test_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,8 @@ def get_exp_util(self, place_site, front_end, pdk_version, layer_stack):
return 56
if pdk_version in ["", "0.3"]:
if place_site == "ra02h138_DST_45CPP":
return 52
if front_end in ["", "slang"]:
return 60
return 61
return 55
return 57
Comment on lines +44 to +45
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a discrepancy between the expected utilization in the test and the actual configuration in config.mk. For PDK version 0.3, config.mk returns 55 for both ra02h138_DST_45CPP and SC6T sites. However, this test only returns 55 for ra02h138_DST_45CPP and defaults to 57 for others (including SC6T), which will cause test failures when PLACE_SITE is set to SC6T.

Suggested change
return 55
return 57
return 55
return 55 if place_site == "SC6T" else 57

Copy link
Copy Markdown
Contributor

@jeffng-or jeffng-or Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore. SC6T is invalid for PDK 0.3. I'll remove SC6T from the conditional in the config.mk in a future commit.

if pdk_version == "t0.5" and place_site == "SC5T":
return 45
if front_end == "verific":
Expand Down