Tightened up hercules_is_int/hercules_idecode core area#4161
Tightened up hercules_is_int/hercules_idecode core area#4161openroad-ci wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates core utilization values and design rules for the hercules_idecode and hercules_is_int designs. Key changes include adjustments to timing and area metrics in the rules configuration files and the addition of new metrics for the finish stage. A discrepancy was identified in the test parameters for hercules_is_int, where the expected utilization for the SC6T site does not match the updated configuration, which could lead to test failures.
| return 55 | ||
| return 57 |
There was a problem hiding this comment.
There is a discrepancy between the expected utilization in the test and the actual configuration in config.mk. For PDK version 0.3, config.mk returns 55 for both ra02h138_DST_45CPP and SC6T sites. However, this test only returns 55 for ra02h138_DST_45CPP and defaults to 57 for others (including SC6T), which will cause test failures when PLACE_SITE is set to SC6T.
| return 55 | |
| return 57 | |
| return 55 | |
| return 55 if place_site == "SC6T" else 57 |
There was a problem hiding this comment.
ignore. SC6T is invalid for PDK 0.3. I'll remove SC6T from the conditional in the config.mk in a future commit.
2 participants
Adjusted hercules_idecode/hercules_is_int area
hercules_idecode base
hercules_idecode verific
hercules_is_int base
hercules_is_int verific