Skip to content

chore: align engines to node >=18.20.8 and pnpm >=10.33.0 #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John-David Dalton (jdalton) merged 2 commits into from
Apr 8, 2026
+12 −8
Merged

chore: align engines to node >=18.20.8 and pnpm >=10.33.0 #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c8d451
chore: align engines to node >=18.20.8 and pnpm >=10.33.0
jdalton Apr 8, 2026
f428ab0
chore: add conventional commits guidance to CLAUDE.md
jdalton Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,17 @@ All shared standards (git, testing, code style, cross-platform, CI) defined in s
- **Update with --update flag**: `pnpm --filter @socketsecurity/cli run test:unit src/commands/specific/cmd-file.test.mts --update`
- **Timeout for long tests**: Use `timeout` command or specify in test file.

### Git Commit Guidelines
### Commit Messages

- Follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) style
- **🚨 FORBIDDEN**: NO AI attribution in commits (see SHARED STANDARDS)
Follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/):

```
<type>(<scope>): <description>

Types: feat, fix, docs, style, refactor, test, chore, perf
```

- **NO AI attribution** in commit messages — the commit-msg hook auto-strips it

### Running the CLI locally

Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"packageManager": "pnpm@10.33.0",
"private": true,
"engines": {
"pnpm": ">=10.22.0"
"node": ">=25.9.0",
"pnpm": ">=10.33.0"
},
"scripts": {
"// Build": "",
Expand Down
4 changes: 0 additions & 4 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,6 @@
"yoctocolors-cjs": "catalog:",
"zod": "catalog:"
},
"engines": {
"node": ">=24.14.0",
"pnpm": ">=10.22.0"
},
"repository": {
"type": "git",
"url": "git+https://github.com/SocketDev/socket-cli.git"
Expand Down