Add Velocity calculation logic and GUI toggle (end-to-end MVP).#1753
Open
M1DNYT3 wants to merge 4 commits intoSlimeVR:mainfrom
Open
Add Velocity calculation logic and GUI toggle (end-to-end MVP).#1753M1DNYT3 wants to merge 4 commits intoSlimeVR:mainfrom
M1DNYT3 wants to merge 4 commits intoSlimeVR:mainfrom
Conversation
b502b9c to
b83d03d
Compare
Author
|
Force pushes in history are changes made by spotless. |
… latest definition from the Driver's main branch.
Author
|
At some point, I had a conversation with @ButterscotchV in DMs, and there was a recommendation expressed to ship the whole feature (Implying a toggle, nothing overkill) in one PR. The description is edited accordingly to reflect each affected part of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes velocity transmission end-to-end, adding RPC settings and a GUI toggle on top of the foundation from #1754.
What's added:
Toggle's GUI Path:
Settings > General > Tracker Settings > Toggle is at the very bottom of the section.
Technicalities:
Most of the line count (~400) comes from regenerated ProtobufMessages.java. The handwritten change itself is small.
Depends on SlimeVR/SolarXR-Protocol#202, should be merged only after the submodule is updated to the tracked HEAD.
Addresses the issue: #25