Skip to content

fix(ci): build workspaces before publish so react finds embed's types #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendersej merged 1 commit into from
Jun 29, 2026
Merged

fix(ci): build workspaces before publish so react finds embed's types #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ jobs:
- name: Install dependencies
run: npm ci

# Build in dependency order (workspaces: embed → react → web) so each package's
# types exist before the next builds. Without this, changeset publish's
# prepublishOnly hooks race: react's rollup type-checks against @simplepdf/embed's
# .d.ts, which isn't generated yet → TS7016 → the publish aborts before anything ships.
- name: Build packages
run: npm run build --workspaces --if-present

- name: Create Release Pull Request or Publish
id: changesets
uses: changesets/action@v1
Expand Down