fix(ci): build workspaces before publish so react finds embed's types#40
Merged
Conversation
… rollup needs embed's types)
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
simplepdf-webhooks | d250f8b | Commit Preview URL Branch Preview URL |
Jun 29 2026, 09:13 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Merging the Version PR (#28) triggered the publish, but it failed before shipping anything (npm still at
@simplepdf/embed@0.4.0/@simplepdf/react-embed-pdf@1.10.0).release.yamlhas no build step — it relies onchangeset publish'sprepublishOnlyhooks. But those don't build in dependency order:react'sprepublishOnly(rollup -c) runs before@simplepdf/embed's type declarations exist, sorpt2can't resolve@simplepdf/embed//tools//ai-sdk(TS7016) and the whole publish aborts.distis gitignored, so CI must build it — and the ordering can't be left to the publish hooks.Changes
release.yamlbuilds all workspaces in dependency order (embed → react → web) before the publish step, so each package's types exist before the next builds.Notes
Verified locally from a clean
dist:npm run build --workspaces --if-presentbuilds embed (8.d.ts) then react with no TS7016, exit 0. Merging this re-runsrelease.yamlonmain(the changesets are already consumed, so it takes the publish path) → builds → publishes0.5.0/1.11.0.