Skip to content

Fix settings tab UI update issue #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leehan273 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix settings tab UI update issue #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,10 +2090,18 @@ export default class VirtualFooterPlugin extends Plugin {
if (rule.renderLocation === RenderLocation.Sidebar && rule.showInSeparateTab) {
const viewId = this.getSeparateViewId(index);
const tabName = rule.sidebarTabName?.trim() ? `Virtual Content: ${rule.sidebarTabName}` : `Virtual Content: Rule ${index + 1}`;
this.registerView(
viewId,
(leaf) => new VirtualContentView(leaf, this, viewId, tabName, () => this.getSeparateTabContent(viewId))
);

try {
this.registerView(
viewId,
(leaf) => new VirtualContentView(leaf, this, viewId, tabName, () => this.getSeparateTabContent(viewId))
);
} catch (error) {
// Calling `this.registerView` when the view already exists, the following error occurs.
// This error doesn't need special handling, but if it is left unhandled, the Settings UI will not update properly.

// console.error(error) // `Error: Attempting to register an existing view type "virtual-content-separate-view-1"`
}
}
});
}
Expand Down