[Feature] Add atomic writes for TOML configuration#8148
Open
Codercise wants to merge 4 commits into
Open
Conversation
This was referenced Jul 22, 2026
Codercise
force-pushed
the
nh/theme-airlock-atomic-toml
branch
from
July 22, 2026 15:15
c315f1f to
8ccf3e3
Compare
Codercise
marked this pull request as ready for review
July 23, 2026 19:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme Airlock needs to update project trust without risking a partially written or corrupted
shopify.theme.toml. ExistingTomlFilemutations write directly to the destination path.This is PR 1 of the Theme Airlock safety stack.
WHAT is this pull request doing?
writeFileAtomicallyfilesystem utility using a unique sibling file and native rename.0600permissions.0600.TomlFilemutation path.@shopify/cli-kitchangeset.This changes the write behavior of
TomlFilecallers across Shopify CLI packages, not only Theme Airlock.Review map
packages/cli-kit/src/public/node/fs.tspackages/cli-kit/src/public/node/toml/toml-file.tspackages/cli-kit/src/public/node/fs.test.tspackages/cli-kit/src/public/node/toml/toml-file.test.tsHow to test your changes?
Verified locally:
Post-release steps
None.
Stack
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add