Skip to content

Up Update CLI option for serverless app home. #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elanalynn wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Up Update CLI option for serverless app home. #7338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/src/cli/prompts/init/init.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('init', () => {
const got = buildNoneTemplate()

// Then
expect(got.label).toBe('Build an extension-only app (Shopify-hosted Preact app home and extensions, no back-end)')
expect(got.label).toBe('Build an extension-only app (Serverless app home and extensions. No back-end)')
expect(got.url).toBe('https://github.com/Shopify/shopify-app-template-extension-only')
})

Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/cli/prompts/init/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function buildNoneTemplate(): Template {
? 'https://github.com/Shopify/shopify-app-template-extension-only'
: 'https://github.com/Shopify/shopify-app-template-none',
label: hostedAppsEnabled
? 'Build an extension-only app (Shopify-hosted Preact app home and extensions, no back-end)'
? 'Build an extension-only app (Serverless app home and extensions. No back-end)'
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hosted-app label uses two sentences inside the parenthesis (period after "extensions") and capitalizes "No", which is inconsistent with the other template labels that use a single parenthetical phrase (e.g., "(recommended)") and tends to read awkwardly in a select list. Consider using a single phrase with comma/semicolon and consistent casing (e.g., "... (Serverless app home and extensions, no back end)"), and keep terminology consistent ("backend" vs "back-end").

Suggested change
? 'Build an extension-only app (Serverless app home and extensions. No back-end)'
? 'Build an extension-only app (Serverless app home and extensions, no backend)'

Copilot uses AI. Check for mistakes.
: 'Build an extension-only app',
Comment on lines 38 to 40
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/intent mentions updating an "up" CLI option for the serverless app home, but the only code change here is a copy update to the init template label. Either update the PR title/description to reflect this wording change, or include the missing CLI option changes in this PR.

Copilot uses AI. Check for mistakes.
visible: true,
}
Expand Down
Loading