Up Update CLI option for serverless app home.#7338
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CLI init prompt label for the extension-only template when hosted apps mode is enabled, reflecting the “serverless app home” wording.
Changes:
- Updated the
buildNoneTemplate()hosted-app label copy in the init prompt. - Updated the corresponding unit test expectation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/app/src/cli/prompts/init/init.ts |
Updates the hosted-app template label shown in the init template selection prompt. |
packages/app/src/cli/prompts/init/init.test.ts |
Adjusts the test to match the new hosted-app label text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| : 'https://github.com/Shopify/shopify-app-template-none', | ||
| label: hostedAppsEnabled | ||
| ? 'Build an extension-only app (Shopify-hosted Preact app home and extensions, no back-end)' | ||
| ? 'Build an extension-only app (Serverless app home and extensions. No back-end)' |
There was a problem hiding this comment.
The hosted-app label uses two sentences inside the parenthesis (period after "extensions") and capitalizes "No", which is inconsistent with the other template labels that use a single parenthetical phrase (e.g., "(recommended)") and tends to read awkwardly in a select list. Consider using a single phrase with comma/semicolon and consistent casing (e.g., "... (Serverless app home and extensions, no back end)"), and keep terminology consistent ("backend" vs "back-end").
| ? 'Build an extension-only app (Serverless app home and extensions. No back-end)' | |
| ? 'Build an extension-only app (Serverless app home and extensions, no backend)' |
| label: hostedAppsEnabled | ||
| ? 'Build an extension-only app (Shopify-hosted Preact app home and extensions, no back-end)' | ||
| ? 'Build an extension-only app (Serverless app home and extensions. No back-end)' | ||
| : 'Build an extension-only app', |
There was a problem hiding this comment.
The PR title/intent mentions updating an "up" CLI option for the serverless app home, but the only code change here is a copy update to the init template label. Either update the PR title/description to reflect this wording change, or include the missing CLI option changes in this PR.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
pnpm changeset add