E2E: parallel workers#7309
Open
phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-store-isolationfrom
Open
E2E: parallel workers#7309phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-store-isolationfrom
phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-store-isolationfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 15, 2026
dbcae8d to
898e174
Compare
6c00722 to
0cf54f5
Compare
898e174 to
fd1b216
Compare
3af2880 to
6e9781e
Compare
6e9781e to
50dc619
Compare
50dc619 to
aa94ef3
Compare
ryancbahan
approved these changes
Apr 16, 2026
isaacroldan
approved these changes
Apr 16, 2026
aa94ef3 to
b4e1649
Compare
5af1692 to
5786612
Compare
b4e1649 to
e654076
Compare
5786612 to
cff5059
Compare
gonzaloriestra
approved these changes
Apr 17, 2026
Contributor
gonzaloriestra
left a comment
There was a problem hiding this comment.
The improvement is great, but it’s still 2x slower than the others...
Have you tried with more workers? Or maybe with shards as we do for Unit tests on Windows?
cff5059 to
f48eb8b
Compare
e654076 to
c6e821f
Compare
f48eb8b to
f13e969
Compare
c6e821f to
e3bf24c
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/upgrade.d.ts@@ -1,5 +1,3 @@
-import { getAutoUpgradeEnabled, setAutoUpgradeEnabled } from '../../private/node/conf-store.js';
-export { getAutoUpgradeEnabled, setAutoUpgradeEnabled };
/**
* Utility function for generating an install command for the user to run
* to install an updated version of Shopify CLI.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Addressed #7268
WHY are these changes introduced?
E2E tests currently run sequentially with 1 worker, making the suite slow (~25 min on CI). With per-test store creation (PR #7279), each store-dependent test adds ~30s of overhead, compounding the problem.
WHAT is this pull request doing?
Enables parallel test execution in
playwright.config.ts:fullyParallel: true— tests run concurrently across workersworkers: 5— 5 parallel Playwright workersglobalTimeout: 20 * 60 * 1000— reduced from 35 min to 20 min (parallel execution is much faster)timeout-minutesreverted from 40 back to 20 (no longer needs the temporary bump from E2E: temporary time limit bump #7282)This is safe because the store isolation PR (#7279) gives each worker its own dev store with unique ports per worker (
SHOPIFY_FLAG_GRAPHIQL_PORT,SHOPIFY_FLAG_THEME_APP_EXTENSION_PORT), preventingEADDRINUSEconflicts. Tests usepnpm(notnpm) for dependency installation, which is reliable under parallel load on CI runners.CI result: Current test suite completes in ~10 min with 5 workers, down from ~27 min with 1 worker. The
globalTimeoutis set to 20 min to leave headroom as more tests will be added — will be re-evaluated once test coverage is finalized.How to test your changes?
Checklist
pnpm changeset add