Skip to content

E2E: temporary time limit bump#7282

Open
phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
psyw-0413-E2E-temporary-time-limit-bump
Open

E2E: temporary time limit bump#7282
phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
psyw-0413-E2E-temporary-time-limit-bump

Conversation

@phyllis-sy-wu
Copy link
Copy Markdown
Contributor

@phyllis-sy-wu phyllis-sy-wu commented Apr 14, 2026

WHY are these changes introduced?

With per-test store creation (next PR in stack), each test that uses app dev now creates and tears down a dev store. This adds ~30s per test, pushing the total suite time over the previous 20-minute Playwright globalTimeout and the 30-minute GitHub Actions job timeout on CI with 1 worker.

WHAT is this pull request doing?

  • Bumps Playwright globalTimeout from 20 min to 35 min in playwright.config.ts
  • Bumps GitHub Actions E2E job timeout-minutes from 30 to 40 in tests-pr.yml

Both are temporary — will be reduced when parallel workers (5 workers) are enabled in #7309, which cuts total suite time significantly.

How to test your changes?

pnpm test:e2e
# Should complete within 35 min on CI without hitting globalTimeout or job timeout

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

phyllis-sy-wu commented Apr 14, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@phyllis-sy-wu phyllis-sy-wu changed the base branch from main to graphite-base/7282 April 14, 2026 02:45
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 8e705aa to 77e5ea0 Compare April 14, 2026 02:45
@phyllis-sy-wu phyllis-sy-wu changed the base branch from graphite-base/7282 to psyw-0413-E2E-improve-error-context-in-assertions April 14, 2026 02:45
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 77e5ea0 to 5765d59 Compare April 14, 2026 04:50
@phyllis-sy-wu phyllis-sy-wu changed the base branch from psyw-0413-E2E-improve-error-context-in-assertions to graphite-base/7282 April 14, 2026 16:48
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 5765d59 to f45019e Compare April 14, 2026 17:11
@phyllis-sy-wu phyllis-sy-wu changed the base branch from graphite-base/7282 to psyw-0413-E2E-improve-error-context-in-assertions April 14, 2026 17:11
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-improve-error-context-in-assertions branch from 3c85425 to c73c96f Compare April 15, 2026 03:26
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch 2 times, most recently from 16b2f4d to e673884 Compare April 15, 2026 13:56
@phyllis-sy-wu phyllis-sy-wu mentioned this pull request Apr 15, 2026
4 tasks
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch 2 times, most recently from dffff76 to 6ee7257 Compare April 15, 2026 17:05
@phyllis-sy-wu phyllis-sy-wu marked this pull request as ready for review April 15, 2026 18:57
@phyllis-sy-wu phyllis-sy-wu requested a review from a team as a code owner April 15, 2026 18:57
@phyllis-sy-wu phyllis-sy-wu linked an issue Apr 15, 2026 that may be closed by this pull request
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-improve-error-context-in-assertions branch from c73c96f to 6cebe1f Compare April 16, 2026 21:18
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 6ee7257 to 37cde2e Compare April 16, 2026 21:18
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-improve-error-context-in-assertions branch from 6cebe1f to b47ba0b Compare April 16, 2026 22:11
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 37cde2e to 6ab5380 Compare April 16, 2026 22:11
Copy link
Copy Markdown
Contributor

Aren't you planning to merge the whole stack together? Maybe you can just skip this PR if it's going to be solved in the next one.

@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 6ab5380 to 887eb1e Compare April 17, 2026 14:10
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-improve-error-context-in-assertions branch from b47ba0b to 7c04ecd Compare April 17, 2026 14:10
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 887eb1e to ec5e775 Compare April 17, 2026 14:13
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-improve-error-context-in-assertions branch from 7c04ecd to 9af58ec Compare April 17, 2026 14:13
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/upgrade.d.ts
@@ -1,5 +1,3 @@
-import { getAutoUpgradeEnabled, setAutoUpgradeEnabled } from '../../private/node/conf-store.js';
-export { getAutoUpgradeEnabled, setAutoUpgradeEnabled };
 /**
  * Utility function for generating an install command for the user to run
  * to install an updated version of Shopify CLI.

@phyllis-sy-wu
Copy link
Copy Markdown
Contributor Author

@gonzaloriestra Thanks for the suggestion! I added this PR as a safety net since the isolation PR (#7279) times out on CI without it and in case I ever need to merge partially. Also, I wasn't sure if the stack would always be merged atomically or sequentially. If it's merged one PR at a time, there'd be a window where CI breaks. But if we can merge the whole stack together, happy to drop this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: Per-test store isolation for robust parallel execution

3 participants