E2E: temporary time limit bump#7282
E2E: temporary time limit bump#7282phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
45cdabf to
d872975
Compare
8e705aa to
77e5ea0
Compare
77e5ea0 to
5765d59
Compare
d872975 to
3c85425
Compare
5765d59 to
f45019e
Compare
3c85425 to
c73c96f
Compare
16b2f4d to
e673884
Compare
dffff76 to
6ee7257
Compare
c73c96f to
6cebe1f
Compare
6ee7257 to
37cde2e
Compare
6cebe1f to
b47ba0b
Compare
37cde2e to
6ab5380
Compare
|
Aren't you planning to merge the whole stack together? Maybe you can just skip this PR if it's going to be solved in the next one. |
6ab5380 to
887eb1e
Compare
b47ba0b to
7c04ecd
Compare
887eb1e to
ec5e775
Compare
7c04ecd to
9af58ec
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/upgrade.d.ts@@ -1,5 +1,3 @@
-import { getAutoUpgradeEnabled, setAutoUpgradeEnabled } from '../../private/node/conf-store.js';
-export { getAutoUpgradeEnabled, setAutoUpgradeEnabled };
/**
* Utility function for generating an install command for the user to run
* to install an updated version of Shopify CLI.
|
|
@gonzaloriestra Thanks for the suggestion! I added this PR as a safety net since the isolation PR (#7279) times out on CI without it and in case I ever need to merge partially. Also, I wasn't sure if the stack would always be merged atomically or sequentially. If it's merged one PR at a time, there'd be a window where CI breaks. But if we can merge the whole stack together, happy to drop this one! |

WHY are these changes introduced?
With per-test store creation (next PR in stack), each test that uses
app devnow creates and tears down a dev store. This adds ~30s per test, pushing the total suite time over the previous 20-minute PlaywrightglobalTimeoutand the 30-minute GitHub Actions job timeout on CI with 1 worker.WHAT is this pull request doing?
globalTimeoutfrom 20 min to 35 min inplaywright.config.tstimeout-minutesfrom 30 to 40 intests-pr.ymlBoth are temporary — will be reduced when parallel workers (5 workers) are enabled in #7309, which cuts total suite time significantly.
How to test your changes?
pnpm test:e2e # Should complete within 35 min on CI without hitting globalTimeout or job timeoutChecklist
pnpm changeset add